Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Python versions in CI were very out of date - 3.6 and 3.7 are now end-of-life and no longer supported. See https://devguide.python.org/versions/
But beyond that a lot of things passed CI only because of specific older versions of tooling (
black
,mypy
,pip
among other things). These problems should be fixed for real but this will at least get CI working again. I will separate PRs for these problems, which are partly formatting but also some type-checking issues (there are quite a lot of type-checking issues) and of course the issue of-VERSION-
as the default version string (really there should be a way to get to semantic versioning...)How Has This Been Tested?
It wasn't tested when first pushed because there isn't any easy way to test GitHub CI recipes 😡 But now it seems to work :)
Checklist