Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't set "dependencies" as empty list for uv toml if there is … #3381

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

monchin
Copy link
Contributor

@monchin monchin commented Jan 16, 2025

…no dependencies in the raw toml file (#3378)

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

fixed #3378

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (d363210) to head (bdfd387).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3381      +/-   ##
==========================================
- Coverage   85.22%   85.22%   -0.01%     
==========================================
  Files         112      112              
  Lines       11494    11493       -1     
  Branches     2520     2520              
==========================================
- Hits         9796     9795       -1     
  Misses       1172     1172              
  Partials      526      526              
Flag Coverage Δ
unittests 85.02% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monchin
Copy link
Contributor Author

monchin commented Jan 16, 2025

The failed test says "Module 'tomli' is missing"

@frostming frostming merged commit 9d11d30 into pdm-project:main Jan 16, 2025
20 of 21 checks passed
@monchin monchin deleted the bugfix#3378 branch January 24, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible uv backend with hatch-odoo
2 participants