Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PDM fails running a script with PEP723 metadata with uv #3383

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

frostming
Copy link
Collaborator

Fixes #3382

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (d363210) to head (c3f5c30).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3383      +/-   ##
==========================================
- Coverage   85.22%   85.22%   -0.01%     
==========================================
  Files         112      112              
  Lines       11494    11493       -1     
  Branches     2520     2520              
==========================================
- Hits         9796     9795       -1     
  Misses       1172     1172              
  Partials      526      526              
Flag Coverage Δ
unittests 85.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming merged commit f86d2cb into main Jan 27, 2025
21 checks passed
@frostming frostming deleted the frostming/issue3382 branch January 27, 2025 02:27
frostming added a commit that referenced this pull request Jan 27, 2025
* fix: PDM fails running a script with  PEP723 metadata with `uv`
Fixes #3382

Signed-off-by: Frost Ming <[email protected]>

* use venv

Signed-off-by: Frost Ming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDM fails running a script with PEP723 metadata with uv
1 participant