fix: ensure dev-dependencies are added to the correct group #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the `group` variable containing the group the user requested was being overridden with the last group processed from the `tool.pdm.dev-dependencies` table, making PDM add dev-dependencies to the wrong group.
1 task
…ginal table This change prevents groups defined in `tool.pdm.dev-dependencies` from being copied to the `dependency-groups` table.
This test should prevent pdm-project#3392 from happening again.
|
@frostming I believe this is now ready for review. :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3393 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 112 112
Lines 11493 11494 +1
Branches 2520 2520
=======================================
+ Hits 9796 9797 +1
Misses 1172 1172
Partials 525 525
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frostming
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
Before this change, the
groupvariable containing the group the user requested was being overridden with the last group processed from thetool.pdm.dev-dependenciestable, making PDM add dev-dependencies to the wrong group.This is a draft PR since #3392 also mentions the duplication of groups betweenFinished!tool.pdm.dev-dependenciesanddependency-groups. I'll be adding the news fragment and test cases in another commit once I finish setting up the dev environment.Fixes #3392.