Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Elixir 1.18 in GitHub CI #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Elixir 1.18 in GitHub CI #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ jobs:
matrix:
include:
- pair:
elixir: 1.13.4
otp: 24.3
elixir: "1.13"
otp: "24"
- pair:
elixir: 1.17.2
otp: 27.0
elixir: "1.18"
otp: "27"
Comment on lines -19 to +23
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify versions as string, see https://github.com/erlef/setup-beam?tab=readme-ov-file#specify-versions-as-strings-not-numbers

lint: lint
steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ defmodule Goth.Mixfile do
{:jose, "~> 1.11"},
{:jason, "~> 1.1"},
{:finch, "~> 0.17"},
{:castore, "~> 1.0", only: :test},
{:bypass, "~> 2.1", only: :test},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

1) test returns {:error, err} when HTTP call fails hard (Goth.ClientTest)
Error:      test/goth/client_test.exs:219
     ** (RuntimeError) default CA trust store not available; please add `:castore` to your project's dependencies or specify the trust store using the :cacertfile/:cacerts option within :transport_options. From OTP 25, you can also use:
     
       * :public_key.cacerts_get/0 to get certificates that you loaded from files or
       * from the OS with :public_key.cacerts_load/0,1
     
     See: https://www.erlang.org/blog/my-otp-25-highlights/#ca-certificates-can-be-fetched-from-the-os-standard-place
     
     code: assert {:error, _} = Client.get_access_token("my-scope")
     stacktrace:
       (mint 1.6.2) lib/mint/core/transport/ssl.ex:7[16](https://github.com/kianmeng/goth/pull/2/checks#step:10:17): Mint.Core.Transport.SSL.raise_on_missing_castore!/0
       (mint 1.6.2) lib/mint/core/transport/ssl.ex:579: Mint.Core.Transport.SSL.add_cacerts/1
       (mint 1.6.2) lib/mint/core/transport/ssl.ex:446: Mint.Core.Transport.SSL.add_verify_opts/2
       (mint 1.6.2) lib/mint/core/transport/ssl.ex:436: Mint.Core.Transport.SSL.ssl_opts/2
       (mint 1.6.2) lib/mint/core/transport/ssl.ex:329: Mint.Core.Transport.SSL.connect/4
       (mint 1.6.2) lib/mint/http1.ex:140: Mint.HTTP1.connect/4
       (finch 0.[19](https://github.com/kianmeng/goth/pull/2/checks#step:10:20).0) lib/finch/http1/conn.ex:52: Finch.HTTP1.Conn.connect/2
       (finch 0.19.0) lib/finch/http1/pool.ex:58: anonymous fn/10 in Finch.HTTP1.Pool.request/6
       (nimble_pool 1.1.0) lib/nimble_pool.ex:462: NimblePool.checkout!/4
       (finch 0.19.0) lib/finch/http1/pool.ex:52: Finch.HTTP1.Pool.request/6
       (finch 0.19.0) lib/finch.ex:493: anonymous fn/4 in Finch.request/3
       (telemetry 1.3.0) /home/runner/work/goth/goth/deps/telemetry/src/telemetry.erl:324: :telemetry.span/3
       (goth 1.4.5) lib/goth/client.ex:75: Goth.Client.get_access_token/3
       test/goth/client_test.exs:[22](https://github.com/kianmeng/goth/pull/2/checks#step:10:23)2: (test)

.............................

Finished in 7.6 seconds (0.6s async, 6.9s sync)
68 tests, 1 failure, 2 excluded

Randomized with seed 726640
Error: Process completed with exit code 2.

{:ex_doc, "~> 0.19", only: :dev},
{:credo, "~> 1.6", only: [:dev, :test], runtime: false},
Expand Down
4 changes: 2 additions & 2 deletions mix.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
"cowboy": {:hex, :cowboy, "2.12.0", "f276d521a1ff88b2b9b4c54d0e753da6c66dd7be6c9fca3d9418b561828a3731", [:make, :rebar3], [{:cowlib, "2.13.0", [hex: :cowlib, repo: "hexpm", optional: false]}, {:ranch, "1.8.0", [hex: :ranch, repo: "hexpm", optional: false]}], "hexpm", "8a7abe6d183372ceb21caa2709bec928ab2b72e18a3911aa1771639bef82651e"},
"cowboy_telemetry": {:hex, :cowboy_telemetry, "0.4.0", "f239f68b588efa7707abce16a84d0d2acf3a0f50571f8bb7f56a15865aae820c", [:rebar3], [{:cowboy, "~> 2.7", [hex: :cowboy, repo: "hexpm", optional: false]}, {:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "7d98bac1ee4565d31b62d59f8823dfd8356a169e7fcbb83831b8a5397404c9de"},
"cowlib": {:hex, :cowlib, "2.13.0", "db8f7505d8332d98ef50a3ef34b34c1afddec7506e4ee4dd4a3a266285d282ca", [:make, :rebar3], [], "hexpm", "e1e1284dc3fc030a64b1ad0d8382ae7e99da46c3246b815318a4b848873800a4"},
"credo": {:hex, :credo, "1.7.10", "6e64fe59be8da5e30a1b96273b247b5cf1cc9e336b5fd66302a64b25749ad44d", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "71fbc9a6b8be21d993deca85bf151df023a3097b01e09a2809d460348561d8cd"},
"credo": {:hex, :credo, "1.7.11", "d3e805f7ddf6c9c854fd36f089649d7cf6ba74c42bc3795d587814e3c9847102", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "56826b4306843253a66e47ae45e98e7d284ee1f95d53d1612bb483f88a8cf219"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

==> credo                                                                                        
Compiling 252 files (.ex)                                                                        
    warning: Credo.CLI.Command.Categories.Output.Default.print_after_info/4 is undefined or priva
te. Did you mean:                                                                                
                                                                                                 
          * print/2                                                                              
                                                                                                 
    │                                                                                            
  4 │   use Credo.CLI.Output.FormatDelegator,                                                    
    │   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                    
    │                                                                                            
    └─ lib/credo/cli/command/categories/categories_output.ex:4: Credo.CLI.Command.Categories.Cate
goriesOutput.print_after_info/4

"dialyxir": {:hex, :dialyxir, "0.5.1", "b331b091720fd93e878137add264bac4f644e1ddae07a70bf7062c7862c4b952", [:mix], [], "hexpm", "6c32a70ed5d452c6650916555b1f96c79af5fc4bf286997f8b15f213de786f73"},
"earmark_parser": {:hex, :earmark_parser, "1.4.41", "ab34711c9dc6212dda44fcd20ecb87ac3f3fce6f0ca2f28d4a00e4154f8cd599", [:mix], [], "hexpm", "a81a04c7e34b6617c2792e291b5a2e57ab316365c2644ddc553bb9ed863ebefa"},
"ex_doc": {:hex, :ex_doc, "0.35.1", "de804c590d3df2d9d5b8aec77d758b00c814b356119b3d4455e4b8a8687aecaf", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "2121c6402c8d44b05622677b761371a759143b958c6c19f6558ff64d0aed40df"},
"file_system": {:hex, :file_system, "1.0.1", "79e8ceaddb0416f8b8cd02a0127bdbababe7bf4a23d2a395b983c1f8b3f73edd", [:mix], [], "hexpm", "4414d1f38863ddf9120720cd976fce5bdde8e91d8283353f0e31850fa89feb9e"},
"file_system": {:hex, :file_system, "1.1.0", "08d232062284546c6c34426997dd7ef6ec9f8bbd090eb91780283c9016840e8f", [:mix], [], "hexpm", "bfcf81244f416871f2a2e15c1b515287faa5db9c6bcf290222206d120b3d43f6"},
"finch": {:hex, :finch, "0.19.0", "c644641491ea854fc5c1bbaef36bfc764e3f08e7185e1f084e35e0672241b76d", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.6.2 or ~> 1.7", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 1.1", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "fc5324ce209125d1e2fa0fcd2634601c52a787aff1cd33ee833664a5af4ea2b6"},
"hpax": {:hex, :hpax, "1.0.1", "c857057f89e8bd71d97d9042e009df2a42705d6d690d54eca84c8b29af0787b0", [:mix], [], "hexpm", "4e2d5a4f76ae1e3048f35ae7adb1641c36265510a2d4638157fbcb53dda38445"},
"jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},
Expand Down