-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper tracks model: more robots #3
Open
peci1
wants to merge
11
commits into
proper-tracks
Choose a base branch
from
proper-tracks-more-models
base: proper-tracks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <[email protected]>
660add1
to
9946f0f
Compare
* Absolem: fix bad merge. * Implement more plausible model of tracks. * Merge upstream thermal cam settings for MARV SC3 * Update with latest changes. * Removed empty wheel slip plugin. * Use power_draining_topic to start battery drain for tracked vehicles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding proper tracks also to the following robots:
These models do not have the battery workaround from #2. If #2 is accepted as a good workaround, I'll add it to these, too.The battery draining is done via
power_draining_topic
battery plugin parameters.I also fixed the Marble HD2 model textures. I've noticed Fuel converted them from PNG to JPEG between model versions 11 and 12, so I also did this change in the repo. I don't know what was the reason behind that change, though (the other teams' HD2 models still use PNG and there is no problem with it).
Coro HD2 had a smaller problem with the textures in repo SDF, so I fixed that, too.