Code Reorganization #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroCabrera
commented
Jul 26, 2024
pedroCabrera
commented
- I reorganized the building output to be included into a package for easy distribution for both windows and linux for all versions using houdini version Env variables.
- Moved samples and otls into the package.
- Added cmakelists.txt and windows_build.bat for easy building in windows.
- Redirected Linux Makefile output to follow the package structure ( only change made to linux build system as i dont work with linux )
- Included flex 1.2 dlls for future work.
pedohorse
requested changes
Aug 28, 2024
| @@ -0,0 +1,7 @@ | |||
| cd ./build | |||
There was a problem hiding this comment.
would be nice to add mkdir -p build before this (not sure about windows cmd analogue) to ensure build dir existence
| @@ -0,0 +1,7 @@ | |||
| cd ./build | |||
| set HOUDINI_PATH=C:\Program Files\Side Effects Software\Houdini 20.5.278\toolkit\cmake | |||
There was a problem hiding this comment.
HOUDINI_PATH is a special houdini control env variable. Even though it does not affect anything here, it would be nice to rename this into something houdini does not use, like HOUDINI_CMAKE_PATH not to confuse the reader, and not to cause problems if someone embeds this script into some testing pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.