Simplify the CurrencyValue protocol #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mordil
added
enhancement
filipealva
approved these changes
Jan 7, 2025
santicarmo31
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations:
The current
CurrencyValueprotocol has a few requirements with default implementations that are not meant to be extension points on the protocol.In addition, a few aspects of how the protocol can be used are a bit rough in either performance or generic ergonomics.
Modifications:
AdditiveArithmeticconformance for free@inlinableannotations to remaining mutating and localization methodsminorUnitsandroundedAmountproperties / initializers to be pure extensionsResult:
Developers are able to use
CurrencyValuein greater generic contexts with slightly better performance capabilities, while also having more protection from incorrectly override expected behavior.