Provide instance level access to descriptor information #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mordil
added
enhancement
Motivation: Sometimes developers are working in type-erased contexts where they can't directly refer to the name of the type of the `CurrencyValue` and need access to the descriptor. In this cases, having an instance member property to provide the value is straight forward and convenient. Modifications: - Add: `descriptor` instance property to `CurrencyValue` - Add: `@inlinable` annotations to both the static and instance member `descriptor` properties Result: Developers now have access to the `CurrencyValue` descriptor type either at the type or instance level.
Mordil
force-pushed
the
instance-descriptor
branch
from
756af82 to
191c9e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes developers are working in type-erased contexts where they can't directly refer to the name of the type of the
CurrencyValueand need access to the descriptor.In this cases, having an instance member property to provide the value is straight forward and convenient.
Modifications:
descriptorinstance property toCurrencyValue@inlinableannotations to both the static and instance memberdescriptorpropertiesResult:
Developers now have access to the
CurrencyValuedescriptor type either at the type or instance level.