Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix User Reference issues #261

Merged
merged 2 commits into from
Dec 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,7 @@
</div>
<div [formGroup]="formGroup$" *ngIf="type === 'dropdown'">
<mat-form-field class="psdk-full-width" subscriptSizing="dynamic" [hintLabel]="helperText">
<mat-select
[value]="value$"
[required]="bRequired$"
[formControl]="fieldControl"
[attr.data-test-id]="testId"
(selectionChange)="fieldOnChange($event)"
>
<mat-select [required]="bRequired$" [formControl]="fieldControl" [attr.data-test-id]="testId" (selectionChange)="fieldOnChange($event)">
<mat-option *ngFor="let opt of options$" [value]="opt.key">
{{ opt.value }}
</mat-option>
Expand All @@ -32,14 +26,12 @@
matInput
[placeholder]="placeholder"
[formControl]="fieldControl"
[value]="value$"
[required]="bRequired$"
[matAutocomplete]="auto"
[attr.data-test-id]="testId"
(change)="fieldOnChange($event)"
(blur)="fieldOnBlur($event)"
/>
<mat-autocomplete #auto="matAutocomplete">
<mat-autocomplete #auto="matAutocomplete" autoActiveFirstOption (optionSelected)="optionChanged($event)">
<mat-option *ngFor="let opt of filteredOptions | async" [value]="opt.value">
<span>{{ opt.value }}</span>
</mat-option>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ interface UserReferenceProps extends Omit<PConnFieldProps, 'value'> {
value?: any;
showAsFormattedText?: boolean;
additionalProps?: object;
onRecordChange?: any;
}

@Component({
Expand Down Expand Up @@ -66,6 +67,7 @@ export class UserReferenceComponent implements OnInit, OnDestroy {
fieldControl = new FormControl('', null);
actionsApi: Object;
propName: string;
onRecordChange: any;

constructor(
private angularPConnect: AngularPConnectService,
Expand All @@ -83,11 +85,11 @@ export class UserReferenceComponent implements OnInit, OnDestroy {
if (this.formGroup$) {
// add control to formGroup
this.formGroup$.addControl(this.controlName$, this.fieldControl);
this.fieldControl.setValue(this.value$);
this.fieldControl.setValue(this.getValue(this.value$));
}

this.filteredOptions = this.fieldControl.valueChanges.pipe(
startWith(''),
startWith(this.getValue(this.value$) || ''),
map(value => this._filter(value || ''))
);
}
Expand Down Expand Up @@ -126,6 +128,21 @@ export class UserReferenceComponent implements OnInit, OnDestroy {
return this.options$?.filter(option => option.value?.toLowerCase().includes(filterVal));
}

isUserNameAvailable = user => {
return typeof user === 'object' && user !== null && user.userName;
};

getUserName = user => {
return user.userName;
};

getValue = user => {
if (this.displayAs$ === DROPDOWN_LIST) {
return this.utils.getUserId(user) || this.getUserName(user);
}
return this.isUserNameAvailable(user) ? this.getUserName(user) : this.utils.getUserId(user);
};

async checkAndUpdate() {
// Should always check the bridge to see if the component should
// update itself (re-render)
Expand All @@ -140,6 +157,7 @@ export class UserReferenceComponent implements OnInit, OnDestroy {
async updateSelf() {
const props = this.pConn$.getConfigProps() as UserReferenceProps;
this.testId = props.testId;
this.onRecordChange = props?.onRecordChange;

const { label, displayAs, value, showAsFormattedText, helperText, placeholder, displayMode } = props;

Expand All @@ -150,20 +168,18 @@ export class UserReferenceComponent implements OnInit, OnDestroy {
this.placeholder = placeholder || '';
this.displayMode$ = displayMode;

this.value$ = this.pConn$.getConfigProps()?.value;

const { readOnly, required } = props;
[this.bReadonly$, this.bRequired$] = [readOnly, required].map(prop => prop === true || (typeof prop === 'string' && prop === 'true'));

this.actionsApi = this.pConn$.getActionsApi();
this.propName = this.pConn$.getStateProps().value;

const isUserNameAvailable = user => {
return typeof user === 'object' && user !== null && user.userName;
};

this.userID$ = this.utils.getUserId(value);

if (this.userID$ && this.bReadonly$ && this.showAsFormattedText$) {
if (isUserNameAvailable(value)) {
if (this.isUserNameAvailable(value)) {
this.userName$ = value.userName;
} else {
// if same user ref field is referred in view as editable & readonly formatted text
Expand Down Expand Up @@ -201,7 +217,12 @@ export class UserReferenceComponent implements OnInit, OnDestroy {
if (event?.target) {
this.filterValue = (event.target as HTMLInputElement).value;
}
const value = event?.target?.value;
const value = event?.value;
handleEvent(this.actionsApi, 'change', this.propName, value);
}

optionChanged(event: any) {
const value = event?.option?.value;
handleEvent(this.actionsApi, 'change', this.propName, value);
}

Expand All @@ -211,11 +232,12 @@ export class UserReferenceComponent implements OnInit, OnDestroy {
const index = this.options$?.findIndex(element => element.value === event.target.value);
key = index > -1 ? (key = this.options$[index].key) : event.target.value;
}

const value = {
value: key
};
const value = key;
handleEvent(this.actionsApi, 'changeNblur', this.propName, value);
if (this.onRecordChange) {
event.target.value = value;
this.onRecordChange(event);
}
}

getErrorMessage() {
Expand Down
Loading