Feature/us 595991 1 - Building different tags and latest to point to jdk17 #208
Conversation
Saurabh-16
changed the title
|
We should probably update our readme to let users know they can select Java version now by choosing different tags |
…he correct jdk image version
There was a problem hiding this comment.
Hi,
Could you please update the following lines in the README with the following text?
Lines 26-28:
To build the Pega image on JDK 11, use pegasystems/pega-ready:3-jdk11 as the base image.
To build the Pega image on JDK 17, use pegasystems/pega-ready:3-jdk17 as the base image.
Currently, the latest tag points to the Pega image on JDK 17, but it may point to later versions in the future, so as a best practice, use tags that specify the version you want to deploy.
Line 38
Building the Pega image on JDK 11. To use images on JDK 17, use the tag 3-jdk17.
Thanks!
Kinga
Addressed. |
| docker build --build-arg VERSION=$(VERSION) -t $(IMAGE_NAME) . # Build image and automatically tag it as latest | ||
| docker build --build-arg VERSION=$(VERSION) --build-arg BASE_TOMCAT_IMAGE=tomcat:9-jdk17 -t $(IMAGE_NAME) . # Build image and automatically tag it as latest on jdk17 | ||
| docker build --build-arg VERSION=$(VERSION) --build-arg BASE_TOMCAT_IMAGE=tomcat:9-jdk11 -t $(IMAGE_NAME):3-jdk11 . # Build image using tomcat 9 , jdk 11 | ||
| docker build --build-arg VERSION=$(VERSION) --build-arg BASE_TOMCAT_IMAGE=tomcat:9-jdk17 -t $(IMAGE_NAME):3-jdk17 . # Build image using tomcat 9 , jdk 17 |
There was a problem hiding this comment.
We can probably just build the jdk17 image once and retag it using docker tag
There was a problem hiding this comment.
This can be done for sure. But in the future latest can be build on any higher jdk version also.
Also I am running java version test cases on the latest tag to ensure it is correctly build on jdk17.
Retagging is happening in push task that is the very last action of the build and before that we want to certify java versions of all the different tags.
Building latest tag separately gives more visibility about the jdk version it is using.
The plan is to publish following tags now.
3-jdk11- Images will be build on jdk113-jdk17- Images will be build on jdk173.1.xxxx-jdk11- Daily Images with the build no. on jdk113.1.xxxx-jdk17- Daily Images with the build no. on jdk17latest- Images will be build on jdk17