Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to missing optional attributes: portalClientSecret and… #449

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

vrseraphin
Copy link
Contributor

… mashupClientSecret

@vrseraphin vrseraphin requested a review from tumms2021389 March 21, 2024 06:52
@tumms2021389 tumms2021389 changed the base branch from main to release/23.1.11-Alpha March 21, 2024 07:07
@tumms2021389 tumms2021389 changed the base branch from release/23.1.11-Alpha to main March 21, 2024 07:07
Copy link
Collaborator

@tumms2021389 tumms2021389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a PR to release/23.1.11-Alpha branch, not main

@vrseraphin
Copy link
Contributor Author

Why not update the comments for this file in main as well? main branch is also pulling in a version of sdk-auth-manager which supports these settings.
I've created the requested change in the other branch as well.

@tumms2021389 tumms2021389 merged commit 14f4a91 into main Mar 27, 2024
3 checks passed
@tumms2021389 tumms2021389 deleted the mod/spr/configClientSecrets branch March 27, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants