Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, wanted to get your take on this idea:
It is possible to have an lxr hash that does not load the bytemap into memory, at the cost of sacrificing almost all performance. The idea is to just have a file pointer open to the bytemap file and use Seek to jump to the appropriate offset, then read a single byte.
This is very inefficient compared to keeping it in RAM so this would only be useful in situations where a low RAM usage is critical. Not suitable for mining.
Regular LXR was ~151ms for 1000 hashes
With an older SATA ssd, LMP was ~7400ms for 1000 hashes
With a newer M.2 ssd, LMP was ~3400ms for 1000 hashes
Anyway, this is probably an unreasonably poor utilization of file i/o that it's not a viable option, just wanted to put it out there.