Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Bangladesh in pelias #298

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

shemul
Copy link

@shemul shemul commented Aug 18, 2022

👋 Hi, I have started a project to onboard Bangladesh in Pelias and start improving address system for Bangladesh. appreciate your help!

Copy link
Member

@missinglink missinglink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution.

Could you please remove the empty sections in pelias.json and add some unit tests as per the other countries.

After that I'd be happy to merge this PR.

"interpolation": { "url": "http://interpolation:4300" },
"libpostal": { "url": "http://libpostal:4400" }
},
"defaultParameters": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this section defaultParameters

"files": [
]
},
"csv": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this empty section csv

"adminLookup": {
"enabled": true
},
"blacklist": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this empty section blacklist

"importPlace": [
]
},
"interpolation": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this empty section interpolation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants