Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set symbol placement on field + support for symbol placement=hidden #48

Merged

Conversation

pelmered
Copy link
Owner

@pelmered pelmered commented Jul 24, 2024

Fixes #44

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.50%. Comparing base (eeb6198) to head (cb84835).

Files Patch % Lines
src/Forms/Components/MoneyInput.php 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #48      +/-   ##
============================================
- Coverage     98.95%   98.50%   -0.46%     
- Complexity       49       54       +5     
============================================
  Files            10       10              
  Lines           192      201       +9     
============================================
+ Hits            190      198       +8     
- Misses            2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pelmered pelmered merged commit 1c26b1a into main Jul 24, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placement of currency symbol/code on input fields set to none doesn't work
1 participant