Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio format fixes #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rakslice
Copy link

@rakslice rakslice commented Jan 15, 2025

  • Use SDL_ConvertAudio to handle output audio conversion
    ** This takes care of 16-bit MSB format audio from the mac to LSB
    ** Also takes care of the case where when the mac is set to 8-bit stereo it sometimes outputs mono SoundComponentData when playing back a mono audio sample on the mac (e.g. stock alert sounds)
  • Switch the 8-bit output format constant to AUDIO_U8 to avoid clicking due to the wrong silence values (this goes with making a change in sdl-1.2 to accept that)

Part of the fix for #7

…atched channels if necessary; switch the 8-bit output format constant to AUDIO_U8 since that is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant