Add fastspell conservative and agressive to the comparison #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is marked as draft because Poetry is failing to install the package. |
|
I managed to find a way to fix the installation error. With Python 3.10, which I'm using, we need to install at least cyhunspell 2.0.3 (which isn't published on PyPI yet). |
|
Thank you Marco. I will deal with your PR shortly. MyPy is reporting type checking failures. Can you fix them please? |
|
You always need to run the Black code formatter as well, please. Otherwise, the build fails. |
|
Yeah, I'm too used to my projects where mypy, black and other linting are run on a commit hook :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188