ci: release assets for darwin/amd64 #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pull request #2323 changed the runner from macos-latest to macos-14. macos-13 and macos-latest are darwin/amd64 but macos-14 is darwin/arm64. So at v0.6.7 https://github.com/pen-lang/pen/releases/tag/v0.6.7 the asset for darwin/arm64 was released instead of darwin/amd64. To release assets for darwin/amd64, this commit adds macos-13 to the build matrix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2326 +/- ##
=======================================
Coverage 87.88% 87.88%
=======================================
Files 455 455
Lines 55042 55042
=======================================
Hits 48375 48375
Misses 6667 6667 ☔ View full report in Codecov by Sentry. |
|
Thank you for the change! |
|
The build failed because the pull request from fork repositories doesn't have the write permission. https://github.com/pen-lang/pen/actions/runs/8011829220/job/21891574723?pr=2326#step:5:3110 |
raviqqe
pushed a commit
that referenced
this pull request
Feb 23, 2024
…positories (#2328) #2326 (comment) The push of docker images failed because GitHub Actions tokens don't have the write permission if pull requests are sent from fork repositories. So this pull request skip pushing docker images if pull requests are sent from fork repositories. ## Test The job passed. https://github.com/pen-lang/pen/actions/runs/8014083453/job/21892121705?pr=2328#step:5:4 ``` push: false ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2327
The pull request #2323 changed the runner from macos-latest to macos-14.
macos-13 and macos-latest are darwin/amd64 but macos-14 is darwin/arm64.
So at v0.6.7 https://github.com/pen-lang/pen/releases/tag/v0.6.7 the asset for darwin/arm64 was released instead of darwin/amd64.
To release assets for darwin/amd64, this pull request adds macos-13 to the build matrix.