Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Github Actions for all deployments #6

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Conversation

neillrobson
Copy link
Collaborator

@neillrobson neillrobson commented Jun 6, 2024

Moving to Github Actions for two reasons:

  • Integration with Github Pages is superior compared with CircleCI
    More generally, deployments to both GCS and Pages are listed on PRs without additional scripting
  • Authorization for non-engineering contributors (e.g. Design team members) to run deployments is more straightforward

To Do

  • Remove dead CircleCI code
  • Remove pr-comment script (assuming it's no longer necessary)
  • Protect main branch against the build job
  • Automatic deploys to Github Pages on main branch

@neillrobson neillrobson self-assigned this Jun 6, 2024
@neillrobson neillrobson temporarily deployed to google-cloud-storage June 6, 2024 15:15 — with GitHub Actions Inactive
@neillrobson neillrobson merged commit c5b0762 into main Jun 6, 2024
2 of 3 checks passed
@neillrobson neillrobson deleted the github-actions branch June 6, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant