Update Pipfile to Correct Linting Dependencies #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyliu-q
reviewed
Feb 1, 2025
| @@ -6,7 +6,7 @@ name = "pypi" | |||
| [packages] | |||
| fastapi = "*" | |||
| pip = "*" | |||
| install = "*" | |||
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
it wouldn't build on my system with install instead of pip-install
literally googled a fix
There was a problem hiding this comment.
might be a python/pip/pipenv version thing but it said that package 'install' couldn't be found
There was a problem hiding this comment.
do you mind linking the stackoverflow/source here?
There was a problem hiding this comment.
Yeah you're not going to like this lol:
neo4j-labs/llm-graph-builder#567
https://pypi.org/project/pip-install/
I think they just changed the name of the package
joyliu-q
reviewed
Feb 1, 2025
| @@ -12,7 +12,7 @@ class Config(BaseSettings): | |||
| REDIS_URL: RedisDsn | |||
|
|
|||
| JWKS_CACHE: JWKSet | None = None | |||
| JWKS_URL: str = "https://platform.pennlabs.org/identity/jwks/" | |||
| JWKS_URL: str = "https://platform.pennlabs.org/accounts/.well-known/jwks.json" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since linting takes place in Github Action, the Pipfile has been updated to have linting packages be standard dependencies so they run successfully on the Github container.