Add User Lifetime Statistics #309

rachllee · 2024-03-27T04:13:25Z

Added a UserStatistics model & relevant methods to track a user's lifetime statistics across all classes

Currently includes:

lifetime number of questions asked
lifetime number of questions answered
lifetime amount of time spent receiving help
lifetime amount of time spent helping
lifetime number of students helped

and I tested them too :)

trangiabach · 2024-03-27T17:11:15Z

Added a UserStatistics model & relevant methods to track a user's lifetime statistics across all classes

Currently includes:

lifetime number of questions asked

lifetime number of questions answered

lifetime amount of time spent receiving help

lifetime amount of time spent helping

lifetime number of students helped

and I tested them too :)

backend god @rachllee

judtinzhang

Great first pass! Didn't look into the test cases, I'll trust you on that. A few comments on most files but most important comments in user_stat.py. Let's talk more about that file at the GBM.

judtinzhang · 2024-03-28T02:32:34Z

backend/ohq/models.py

@@ -411,3 +411,35 @@ class Announcement(models.Model):
    author = models.ForeignKey(User, related_name="announcements", on_delete=models.CASCADE)
    time_updated = models.DateTimeField(auto_now=True)
    course = models.ForeignKey(Course, related_name="announcements", on_delete=models.CASCADE)
+
+
+class UserStatistic(models.Model):


judtinzhang · 2024-03-28T02:33:02Z

backend/package-lock.json

@@ -0,0 +1,27 @@
+{


not sure what package-lock is here? should remove

I'm actually also unsure- it appeared during my very convoluted env setup process but I will manually delete

judtinzhang · 2024-03-28T02:33:07Z

backend/package.json

@@ -0,0 +1,5 @@
+{


judtinzhang · 2024-03-28T02:43:06Z

backend/ohq/statistics.py

+
+
+def user_calculate_questions_answered(user):
+    num_questions = Decimal(Question.objects.filter(responded_to_by=user).count())


nit: should add status=Question.STATUS_ANSWERED to make the query more accurate

judtinzhang · 2024-03-30T23:16:17Z

backend/ohq/statistics.py

+
+def user_calculate_time_helped(user):
+    user_time_helped = (
+        Question.objects.filter(asked_by=user)


Does this query work if the question was rejected or withdrawn? In that case the time_response_started field would be null. If it doesn't, perhaps filter for where the question status is answered?

judtinzhang · 2024-03-30T23:19:45Z

backend/ohq/statistics.py

+    UserStatistic.objects.update_or_create(
+        user=user,
+        metric=UserStatistic.METRIC_TOTAL_TIME_BEING_HELPED,
+        defaults={"value": time.seconds if time else Decimal('0.00000000')},


I am more inclined to not call update_or_create at all if time.seconds is None instead of updating the value to be 0.

judtinzhang · 2024-03-30T23:20:15Z

backend/ohq/statistics.py

+
+
+def user_calculate_time_helping(user):
+    user_time_helping = (


ditto for comments regarding user_calculate_time_helped

judtinzhang · 2024-03-30T23:29:05Z

backend/ohq/management/commands/user_stat.py

+                    else yesterday
+                )
+
+            course_questions = Question.objects.filter(queue__course=course, time_asked__gte=date)


from django.db.models import Q questions_queryset = Question.objects.filter(queue__course=course, time_asked__gte=date) users_union = ( User.objects.filter( Q(id__in=questions_queryset.values_list("asked_by", flat=True)) | Q(id__in=questions_queryset.values_list("responded_to_by", flat=True)) ) )

judtinzhang · 2024-03-30T23:30:46Z

backend/ohq/management/commands/user_stat.py

+    def add_arguments(self, parser):
+        parser.add_argument("--hist", action="store_true", help="Calculate all historic statistics")
+
+    def calculate_statistics(self, profiles, courses, earliest_date):


The earliest_date parameter here is used to compute a date field, which I don't think is quite necessary. I think we can directly just use the earliest_date field wherever date is used.

judtinzhang · 2024-03-30T23:31:30Z

backend/ohq/management/commands/user_stat.py

+                active_users_today.add(q.asked_by)
+                active_users_today.add(q.responded_to_by)
+
+        for profile in profiles:


This might be slow because we are iterating over all profiles, it is probably best to do this in the DB somehow (like the code snippet from above)

judtinzhang

Almost there! Few nits

judtinzhang · 2024-04-02T17:04:50Z

backend/Pipfile

@@ -45,4 +45,4 @@ typing-extensions = "*"
 drf-excel = "*"

 [requires]
-python_version = "3"


I'm not quite sure why the Pipfile and Pipfile.lock are changed. In general, if there are no dependency changes, we shouldn't touch these cause they're read directly from our production machines to install. Would suggest following this article to remove these changes from the PR

I tried to fix this with the stackoverflow article but it kind of does not look like it did anything per the last commit- I think I could use some help with this at GBM

sounds good

judtinzhang · 2024-04-02T17:07:40Z

backend/ohq/statistics.py

+def user_calculate_questions_asked(user):
+    num_questions = Question.objects.filter(asked_by=user).count()
+
+    if num_questions and not num_questions == 0:


nit: I think you can just write if num_questions:. If num_questions is ever 0, the if statement would fail (0 is considered False)

judtinzhang · 2024-04-02T17:08:47Z

backend/ohq/statistics.py

+    )
+    time = user_time_helped["time_helped"]
+
+    if time and not math.isclose(time.total_seconds(), 0, abs_tol=0.001):


Question: is there a reason you use time.total_seconds() here, but a few lines down you use time.seconds? Is there a difference?

lol nope I don't think there's a difference I was just copying off of the documentation- I'll change it to .seconds for consistency

judtinzhang · 2024-04-02T17:11:59Z

backend/ohq/management/commands/user_stat.py

+
+
+
+class Command(BaseCommand):


Let's talk about this file on Friday!

judtinzhang

Almost there! Few nits. Please also run all the necessary linting for backend as well to format your code. I'm not sure how OHQ does it so please ask @trangiabach for that. One more detail as well that I'll message you about on slack

judtinzhang · 2024-04-08T02:51:09Z

backend/ohq/management/commands/course_stat.py

@@ -1,5 +1,6 @@
 from django.core.management.base import BaseCommand
 from django.utils import timezone
+import datetime


nit: think we can remove this line

judtinzhang · 2024-04-08T02:51:51Z

backend/ohq/management/commands/user_stat.py

+                    user_calculate_students_helped(user)
+
+
+    def handle(self, *args, **kwargs):


looks a lot cleaner, good work!

judtinzhang · 2024-04-08T02:59:44Z

Nevermind, false alarm. Just that 1 nit and linting then we are good!

judtinzhang

LGTM!! Congrats on your first finished PR :D

danielxue

lgtm!

user analytics backend

3fc9869

rachllee requested review from danielxue, trangiabach and judtinzhang March 27, 2024 04:13

judtinzhang reviewed Mar 30, 2024

View reviewed changes

float point & other bug fixes

0644d8e

judtinzhang reviewed Apr 2, 2024

View reviewed changes

rachllee added 3 commits April 3, 2024 13:10

minor syntax stuff

1846594

pipfile stuff

2ee7af0

user logic & timezone fix

4b6fe90

judtinzhang reviewed Apr 8, 2024

View reviewed changes

rachllee and others added 2 commits April 8, 2024 19:12

remove import

a22aabc

lint changes

247e26c

judtinzhang approved these changes Apr 14, 2024

View reviewed changes

danielxue approved these changes Apr 14, 2024

View reviewed changes

rachllee merged commit b6b6d86 into master Apr 14, 2024
5 checks passed

rachllee deleted the user-analytics branch April 14, 2024 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add User Lifetime Statistics #309

Add User Lifetime Statistics #309

rachllee commented Mar 27, 2024

trangiabach commented Mar 27, 2024

judtinzhang left a comment

judtinzhang Mar 28, 2024

judtinzhang Mar 28, 2024

rachllee Apr 1, 2024

judtinzhang Mar 28, 2024

judtinzhang Mar 28, 2024

judtinzhang Mar 30, 2024

judtinzhang Mar 30, 2024

judtinzhang Mar 30, 2024

judtinzhang Mar 30, 2024

judtinzhang Mar 30, 2024

judtinzhang Mar 30, 2024

judtinzhang left a comment

judtinzhang Apr 2, 2024

rachllee Apr 3, 2024

judtinzhang Apr 3, 2024

judtinzhang Apr 2, 2024 •

edited

Loading

judtinzhang Apr 2, 2024

rachllee Apr 3, 2024

judtinzhang Apr 2, 2024

judtinzhang left a comment

judtinzhang Apr 8, 2024

judtinzhang Apr 8, 2024

judtinzhang commented Apr 8, 2024

judtinzhang left a comment

danielxue left a comment



		def user_calculate_questions_answered(user):
		num_questions = Decimal(Question.objects.filter(responded_to_by=user).count())

		user_calculate_students_helped(user)


		def handle(self, args, *kwargs):

Add User Lifetime Statistics #309

Add User Lifetime Statistics #309

Conversation

rachllee commented Mar 27, 2024

trangiabach commented Mar 27, 2024

judtinzhang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

judtinzhang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

judtinzhang Apr 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

judtinzhang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

judtinzhang commented Apr 8, 2024

judtinzhang left a comment

Choose a reason for hiding this comment

danielxue left a comment

Choose a reason for hiding this comment

judtinzhang Apr 2, 2024 •

edited

Loading