fix(club.membership_count): deprecate club membership count, use club…

….members.length instead (#579)
pennlabs · Sep 1, 2023 · 7667459 · 7667459
1 parent 9707966
commit 7667459
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/frontend/components/ClubPage/InfoBox.tsx b/frontend/components/ClubPage/InfoBox.tsx
@@ -40,9 +40,9 @@ const InfoBox = (props: InfoBoxProps): ReactElement | null => {
       field: 'size',
       icon: 'user',
       alt: 'members',
-      text: `${props.club.membership_count} Registered (${getSizeDisplay(
-        props.club.size,
-      )})`,
+      text: `${
+        props.club.membership_count ?? props.club.members.length
+      } Registered (${getSizeDisplay(props.club.size)})`,
     },
     {
       field: 'accepting_members',

diff --git a/frontend/types.ts b/frontend/types.ts
@@ -169,6 +169,10 @@ export interface Club {
   linkedin: string
   listserv: string
   members: Membership[]
+  /**
+   * @deprecated
+   * use `members.length` instead
+   */
   membership_count: number
   name: string
   recruiting_cycle: ClubRecruitingCycle