Updated Penn Events Tab but w/out Club Events (yet) #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and end dates from backend API, new events API manager, and updated PennEventsView to populate events)
…ventsViewModel (grouping into college houses, engineering, wharton, penn today, venture lab, all)
…itch when in features grid), reason was due to nested navigationViews
…nd event type string to find coordinates for mapview
…e categorization, and using that as another way to query for location, also reordered order of querying and looks at event type first (college houses first)
…eating separate coordinate and region vars (finally)
…to jackyf/events
anli5005
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Aside from a few nits, nice work!
Will defer to @JHawk0224 on anything brought up in the review
JHawk0224
requested changes
Apr 26, 2024
JHawk0224
requested changes
Sep 29, 2024
… to PennLocation, removed PennEventViewModel
…t + new isVirtual bool flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.