Fix Laundry Snapshot Collection #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuneerroy
commented
Nov 6, 2023
tuneerroy
commented
- Fixes off-by-1 error when accumulating snapshot data
- Refactors some shoddily written code
tuneerroy
commented
Nov 6, 2023
backend/laundry/views.py
Outdated
| new_start = start - datetime.timedelta(weeks=week) | ||
| new_end = new_start + datetime.timedelta(hours=27) | ||
| filter |= Q(date__gt=new_start, date__lt=new_end) |
There was a problem hiding this comment.
the lt instead of the lte should avoid the off by one
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 89.81% 89.80% -0.02%
==========================================
Files 53 53
Lines 2259 2255 -4
==========================================
- Hits 2029 2025 -4
Misses 230 230
☔ View full report in Codecov by Sentry. |
judtinzhang
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.