Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Laundry Patch #227

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Temporary Laundry Patch #227

merged 3 commits into from
Nov 9, 2023

Conversation

tuneerroy
Copy link
Contributor

Previous attempt at a solution failed. This is a dumber but more guaranteed way to avoid the error. Will investigate and revert later once root issue is identified.

@tuneerroy tuneerroy requested a review from judtinzhang November 9, 2023 22:33
Copy link
Member

@judtinzhang judtinzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me haha. Can we confirm with someone on iOS that this increase in data size doesn't affect their code before pushing?

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ae2611) 89.80% compared to head (4efa9e6) 89.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   89.80%   89.80%           
=======================================
  Files          53       53           
  Lines        2255     2255           
=======================================
  Hits         2025     2025           
  Misses        230      230           
Files Coverage Δ
backend/laundry/views.py 90.42% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuneerroy
Copy link
Contributor Author

tuneerroy commented Nov 9, 2023

Seems reasonable to me haha. Can we confirm with someone on iOS that this increase in data size doesn't affect their code before pushing?

Jordan says it's fine. If it's breaks: his fault. :)

@tuneerroy tuneerroy merged commit b501681 into master Nov 9, 2023
9 checks passed
@tuneerroy tuneerroy deleted the fix-laundry-2 branch November 9, 2023 23:22
tuneerroy added a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants