Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "GSR Revamp" #236

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Revert "GSR Revamp" #236

merged 1 commit into from
Dec 12, 2023

Conversation

vcai122
Copy link
Contributor

@vcai122 vcai122 commented Dec 12, 2023

Reverts #224

This reverts commit f660ef4.
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (776dab2) 91.27% compared to head (67a605e) 89.87%.

Files Patch % Lines
backend/gsr_booking/api_wrapper.py 77.35% 53 Missing ⚠️
backend/gsr_booking/group_logic.py 83.63% 9 Missing ⚠️
backend/gsr_booking/models.py 30.76% 9 Missing ⚠️
backend/gsr_booking/views.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   91.27%   89.87%   -1.40%     
==========================================
  Files          58       59       +1     
  Lines        2417     2549     +132     
==========================================
+ Hits         2206     2291      +85     
- Misses        211      258      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vcai122 vcai122 merged commit d5bbcda into master Dec 12, 2023
7 of 9 checks passed
@vcai122 vcai122 deleted the revert-224-gsr-revamp branch December 12, 2023 19:04
Copy link

sentry-io bot commented Dec 21, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ JSONDecodeError: Expecting value: line 1 column 1 (char 0) /api/gsr/book/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants