Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy #322

Merged
merged 16 commits into from
Nov 14, 2024
Merged

Add mypy #322

merged 16 commits into from
Nov 14, 2024

Conversation

ashleyzhang01
Copy link
Contributor

@ashleyzhang01 ashleyzhang01 commented Nov 11, 2024

fixing type errors, getting rid of anys
todo after fixing: schemas, unused params, organize types

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 94.59746% with 51 lines in your changes missing coverage. Please review.

Project coverage is 90.94%. Comparing base (96a605c) to head (f6034f9).
Report is 10 commits behind head on add-type-safety.

Files with missing lines Patch % Lines
backend/sublet/views.py 87.64% 11 Missing ⚠️
backend/pennmobile/admin.py 56.25% 7 Missing ⚠️
backend/portal/permissions.py 84.21% 6 Missing ⚠️
backend/sublet/serializers.py 90.90% 5 Missing ⚠️
...nndata/management/commands/get_fitness_snapshot.py 63.63% 4 Missing ⚠️
backend/gsr_booking/admin.py 70.00% 3 Missing ⚠️
backend/gsr_booking/models.py 94.91% 3 Missing ⚠️
backend/gsr_booking/api_wrapper.py 96.55% 2 Missing ⚠️
backend/utils/email.py 81.81% 2 Missing ⚠️
backend/dining/api_wrapper.py 90.90% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           add-type-safety     #322      +/-   ##
===================================================
+ Coverage            90.86%   90.94%   +0.07%     
===================================================
  Files                   63       64       +1     
  Lines                 2661     2903     +242     
===================================================
+ Hits                  2418     2640     +222     
- Misses                 243      263      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashleyzhang01 ashleyzhang01 marked this pull request as ready for review November 14, 2024 00:15
@ashleyzhang01 ashleyzhang01 merged commit 43daeaa into add-type-safety Nov 14, 2024
4 checks passed
@ashleyzhang01 ashleyzhang01 deleted the add-mypy branch November 14, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants