Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Anyone Delete Token #330

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Allow Anyone Delete Token #330

merged 2 commits into from
Nov 18, 2024

Conversation

vcai122
Copy link
Contributor

@vcai122 vcai122 commented Nov 18, 2024

This feels a little bad. The assumption we are making is that people will not get ahold of someone else's device's notification token.

But the worst that could happen is the attacker can hijack notifications sent to the device. The attacker will never get ahold of notifications actually meant for the user since users must be logged in to become associated with a particular token.

TODO: add test in later PR

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (b1a8bfa) to head (b036cce).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   88.52%   88.49%   -0.03%     
==========================================
  Files          67       67              
  Lines        2762     2765       +3     
==========================================
+ Hits         2445     2447       +2     
- Misses        317      318       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@vcai122 vcai122 merged commit 00587a3 into master Nov 18, 2024
8 of 9 checks passed
@vcai122 vcai122 deleted the allow-anyone-to-delete-token branch November 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant