-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PASE-1974: pmc-larva should support cookie consent category #840
Conversation
Deploy preview for pmc-larva ready! ✅ Preview Built with commit cce05a6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we handled this in WP, when the loader script is enqueued. Is that not the case?
@ethitter we do, in that pmc cookies aren't set when a user rejects all cookie categories. However, this lets us pass in a category when calling You're right though - there is a lot of existing code related to this behavior: |
We don't really need this, since |
Per PASE-1974, we need to check for OneTrust cookie consent before setting cookie using
pmc.cookie.set()
. This passes in a category of 'functional' for thewebfont loaded
cookie setting.Relates to https://github.com/penske-media-corp/pmc-plugins/pull/4102/
Unpublished
section