Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PASE-2049 | Resolve ESLint errors #861

Merged
merged 82 commits into from
Feb 18, 2025
Merged

PASE-2049 | Resolve ESLint errors #861

merged 82 commits into from
Feb 18, 2025

Conversation

JordanPak
Copy link
Contributor

@JordanPak JordanPak commented Sep 10, 2024 •
edited
Loading

Summary

Resolves ESLint warnings and errors that can prevent scripts from building.

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

nayeonk and others added 24 commits April 30, 2024 11:49
@nayeonk
Apply linter fixes
077177c
@nayeonk
Testing so far
308f1b6
@JordanPak
Merge remote-tracking branch 'origin/master' into feature/PASE-2049
582b1bb
@JordanPak
Remove seemingly-outdated @wordpress/no-global-event-listener ignore
11b5941
@JordanPak
Apply lint-fix to a couple files
ebe3ab2
@JordanPak
Make prod:js happy with VideoShowcase eslint-wise
e8bf55e
@JordanPak
Address misc eslint issues in prod:js that were preventing builds to …
2c9cf64 
…update correctly
@JordanPak
Update package lock with some jest stuff someone apparently thinks we…
e18046a 
… need
@nayeonk
Add claryfing comments on eslint config files
eb32d6e
@nayeonk
Disable camelcase for larva eslint rule
06754b8
@JordanPak
Ignore ESLint import/no-extraneous-dependencies (Larva package)
6c45b50
@JordanPak
Resolve "config is already in outside scope" issue in twig-to-php-parser
51ca619
@JordanPak
Resolve ESLint issues with twig-to-php-parser
67be3f9
@JordanPak
Allow console.log for error in twig-to-php-parser/getConfig
096ce6a
@JordanPak
Address ESLint issues in css-algo/rule.js
cff4c13
@JordanPak
Merge remote-tracking branch 'origin/master' into feature/PASE-2049
1d954b5
@JordanPak
Address ESLint findings on stylelint-config/.../custom-formatter.js
4b5f3dc
@JordanPak
Remove duplicate stylelint rules
56f0a8e
@JordanPak
sort stylelint rules alphabetically
95739a9
@JordanPak
Make Prettier happy
a537c4a
@JordanPak
Add missing return types
a0b84af
@JordanPak
Add React compatibility to larva package ESLint
15c4f6b
@JordanPak
Merge remote-tracking branch 'origin/master' into feature/PASE-2049
334b9fd
@JordanPak
Swap ReactDOM.render with React client createRoot
ea6639e
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-dckq3xugy-penske-media-corp.vercel.app

Built with commit 61f9402.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

🚨 Backstop Visual Regression Tests Failed: View the results for 3a2d37030f590bc47cafe71266fb317f73a3fcda.

How to view and update regression tests
  1. View the failing build.
  2. Look under the section titled "Artifacts".
  3. Download the backstop-results artifact.
  4. On your local machine, open backstop-results/html-report/index.html in a browser to view the screenshot comparison.

💍 When the results contain changes you want to retain

Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.

@github-actions GitHub Actions
Copy link
Contributor

🚨 Backstop Visual Regression Tests Failed: View the results for e8fdeb2adbeaee2c3a8757ae21779da6c851c49d.

How to view and update regression tests
  1. View the failing build.
  2. Look under the section titled "Artifacts".
  3. Download the backstop-results artifact.
  4. On your local machine, open backstop-results/html-report/index.html in a browser to view the screenshot comparison.

💍 When the results contain changes you want to retain

Run the Update Visual Regression Tests workflow on this feature branch. This will create a new branch with reference screenshots. Then you will need to open a pull request to this branch to update it.

marcagarcia and others added 15 commits February 4, 2025 14:17
@marcagarcia
help.js script linting
2baae2e
@marcagarcia
Merge branch 'feature/PASE-2049' of github.com:penske-media-corp/pmc-…
3f3271d 
…larva into feature/PASE-2049
@marcagarcia
Fix parsing error return outside of function with process.exit( 0 )
e827356
@marcagarcia
Swap console logs with process write
307d4fb
@JordanPak
Fix var scoping in pmc-footer
75e6af0
@JordanPak
Remove unused title component prototype in product-grid
f49b903
@JordanPak
Remove undefined array value in how-we-test-products
8aa8506
@JordanPak
Address misc undefined constants + unused constants
3bb9e04
@JordanPak
Address undefined consts in age-gate prototype
d9d8eb4
@JordanPak
Ignore duplicate object key (there's styling on both!)
02d97b5
@JordanPak
Note globals and remove unused vars from webfont config
1f77ee0
@JordanPak
Fix minor JS lint issues in larva-js/src/interface
688015a
@JordanPak
Move MobileHeightToggle test into __test__ dir so ESLint doesn't frea…
af2ae7d 
…k out
@JordanPak
Remove unused event params :D
99b6110
@JordanPak
Update changelog
76bd965
@JordanPak JordanPak marked this pull request as ready for review February 18, 2025 14:50
marcagarcia
marcagarcia approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@marcagarcia marcagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

shawncook
shawncook approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@shawncook shawncook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@JordanPak JordanPak merged commit 858e8dc into master Feb 18, 2025
3 checks passed
@JordanPak JordanPak deleted the feature/PASE-2049 branch February 18, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawncook shawncook shawncook approved these changes

@marcagarcia marcagarcia marcagarcia approved these changes

@rsalvucci rsalvucci rsalvucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JordanPak @shawncook @marcagarcia @rsalvucci @nayeonk