Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORP-620: Add aria-label attribute for c-button component #877

Merged
merged 2 commits into from
Feb 20, 2025
Merged

CORP-620: Add aria-label attribute for c-button component #877

merged 2 commits into from
Feb 20, 2025

Conversation

deepaklalwani97
Copy link
Collaborator

@deepaklalwani97 deepaklalwani97 commented Feb 20, 2025 •
edited
Loading

Summary

Add aria-label attribute for c-button component

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

@github-actions GitHub Actions
Copy link
Contributor

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-auunncyqy-penske-media-corp.vercel.app

Built with commit b883f66.
This pull request is being automatically deployed with vercel-action

@deepaklalwani97 deepaklalwani97 marked this pull request as ready for review February 20, 2025 15:59
@deepaklalwani97 deepaklalwani97 merged commit 2e5e9e3 into master Feb 20, 2025
3 checks passed
@deepaklalwani97 deepaklalwani97 deleted the feature/CORP-620 branch February 20, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauteri mauteri mauteri approved these changes

@marcagarcia marcagarcia marcagarcia approved these changes

@rsalvucci rsalvucci rsalvucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepaklalwani97 @mauteri @marcagarcia @rsalvucci