Skip to content

Commit

Permalink
Workaround for ManagedBy::update() problem in ProxyManager
Browse files Browse the repository at this point in the history
This method signature should be compatible with 7.1 nullable types `?string $firstname, ?string $lastname`.

ATM (12.11.2016.) there are bugs in two projects:
1. zendframework/zend-code#85
2. Ocramius/ProxyManager#327

These are blockers for 7.1 syntax.
  • Loading branch information
perajovic committed Nov 12, 2016
1 parent 13e55bb commit 21a0f07
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion src/Filos/FrameworkBundle/Model/ManagedBy.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,17 @@ public static function create(
return $managedBy;
}

public function update(string $email, ?string $firstname, ?string $lastname)
/**
* @todo
*
* This method signature should be compatible with 7.1 nullable types `?string $firstname, ?string $lastname`.
* ATM (12.11.2016.) there are bugs in two projects:
* 1. https://github.com/zendframework/zend-code/issues/85
* 2. https://github.com/Ocramius/ProxyManager/pull/327
*
* They are blockers for 7.1 syntax.
*/
public function update(string $email, string $firstname = null, string $lastname = null)
{
$this->email = $email;
$this->firstname = $firstname;
Expand Down

0 comments on commit 21a0f07

Please sign in to comment.