Merge pull request #85 from percolatestudio/feature/modules

ES update
percolatestudio · Oct 24, 2022 · 778094e · 778094e
2 parents 956f1b8 + 3dd7d07
commit 778094e
Show file tree

Hide file tree

Showing 10 changed files with 173 additions and 108 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -0,0 +1,32 @@
+name: Test
+on: push
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        meteorRelease:
+          - '--release 1.9.3'
+          - '--release 1.12.1'
+          - '--release 2.1.1'
+          - '--release 2.3.5'
+          - '--release 2.8.0'
+          # Latest version
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Install Node.js
+        uses: actions/setup-node@v1
+        with:
+          node-version: '14.x'
+
+      - name: Install Dependencies
+        run: |
+          curl https://install.meteor.com | /bin/sh
+          npm i -g @zodern/mtest
+      - name: Run Tests
+        run: |
+          # Retry tests since some of them are flaky
+          mtest --package ./ --once ${{ matrix.meteorRelease }} || mtest --package ./ --once ${{ matrix.meteorRelease }}
diff --git a/.travis.yml b/.travis.yml
@@ -1,5 +1,5 @@
 language: node_js
-node_js: "0.10"
+node_js: "12"
 sudo: false
 install:
   - "curl https://install.meteor.com | /bin/sh"

diff --git a/example/.meteor/.finished-upgraders b/example/.meteor/.finished-upgraders
@@ -10,3 +10,10 @@ notices-for-facebook-graph-api-2
 1.2.0-meteor-platform-split
 1.2.0-cordova-changes
 1.2.0-breaking-changes
+1.3.0-split-minifiers-package
+1.4.0-remove-old-dev-bundle-link
+1.4.1-add-shell-server-package
+1.4.3-split-account-service-packages
+1.5-add-dynamic-import-package
+1.7-split-underscore-from-meteor-base
+1.8.3-split-jquery-from-blaze
diff --git a/example/.meteor/packages b/example/.meteor/packages
@@ -3,20 +3,24 @@
 # 'meteor add' and 'meteor remove' will edit this file for you,
 # but you can also edit it by hand.
 
-autopublish
-insecure
+autopublish@1.0.7
+insecure@1.0.7
 percolate:migrations
-standard-minifiers
-meteor-base
-mobile-experience
-mongo
+[email protected]
+[email protected]
+[email protected]
 blaze-html-templates
-session
+session@1.2.0
 jquery
-tracker
-logging
-reload
-random
-ejson
+tracker@1.2.0
+logging@1.3.1
+reload@1.3.1
+random@1.2.0
+ejson@1.1.2
 spacebars
-check
+[email protected]
+standard-minifier-css
+standard-minifier-js
+shell-server
+dynamic-import
+underscore
diff --git a/example/.meteor/release b/example/.meteor/release
@@ -1 +1 @@
-METEOR@1.2.0.2
+METEOR@2.8.0
diff --git a/example/.meteor/versions b/example/.meteor/versions
@@ -1,66 +1,80 @@
-[email protected]
-[email protected]
-[email protected]_1
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]_1
-[email protected]
-[email protected]
-percolate:[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
-[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+percolate:[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
+[email protected]
diff --git a/migrations_server.js b/migrations_server.js
@@ -1,3 +1,7 @@
+import { Meteor } from 'meteor/meteor';
+import { check, Match } from 'meteor/check';
+import { Log } from 'meteor/logging';
+
 /*
   Adds migration capabilities. Migrations are defined like:
 
@@ -23,14 +27,14 @@
   Note: Migrations will lock ensuring only 1 app can be migrating at once. If
   a migration crashes, the control record in the migrations collection will
   remain locked and at the version it was at previously, however the db could
-  be in an inconsistant state.
+  be in an inconsistent state.
 */
 
 // since we'll be at version 0 by default, we should have a migration set for
 // it.
-var DefaultMigration = { version: 0, up: function() {} };
+const DefaultMigration = { version: 0, up: function() {} };
 
-Migrations = {
+export const Migrations = {
   _list: [DefaultMigration],
   options: {
     // false disables logging
@@ -43,7 +47,7 @@ Migrations = {
     collectionName: 'migrations',
   },
   config: function(opts) {
-    this.options = _.extend({}, this.options, opts);
+    this.options = Object.assign({}, this.options, opts);
   },
 };
 
@@ -68,7 +72,7 @@ function createLogger(prefix) {
     check(level, Match.OneOf('info', 'error', 'warn', 'debug'));
     check(message, String);
 
-    var logger = Migrations.options && Migrations.options.logger;
+    const logger = Migrations.options && Migrations.options.logger;
 
     if (logger && _.isFunction(logger)) {
       logger({
@@ -82,10 +86,10 @@ function createLogger(prefix) {
   };
 }
 
-var log;
+let log;
 
 Meteor.startup(function() {
-  var options = Migrations.options;
+  const options = Migrations.options;
 
   // collection holding the control record
   Migrations._collection = new Mongo.Collection(options.collectionName);
@@ -128,18 +132,20 @@ Migrations.add = function(migration) {
 // e.g 'latest', 'latest,exit', 2
 // use 'XX,rerun' to re-run the migration at that version
 Migrations.migrateTo = function(command) {
-  if (_.isUndefined(command) || command === '' || this._list.length === 0)
+  if (typeof command === 'undefined' || command === '' || this._list.length === 0)
     throw new Error('Cannot migrate using invalid command: ' + command);
 
+  let version;
+  let subcommand;
   if (typeof command === 'number') {
-    var version = command;
+    version = command;
   } else {
-    var version = command.split(',')[0]; //.trim();
-    var subcommand = command.split(',')[1]; //.trim();
+    version = command.split(',')[0]; //.trim();
+    subcommand = command.split(',')[1]; //.trim();
   }
 
   if (version === 'latest') {
-    this._migrateTo(_.last(this._list).version);
+    this._migrateTo(this._list[this._list.length -1].version);
   } else {
     this._migrateTo(parseInt(version), subcommand === 'rerun');
   }
@@ -155,9 +161,9 @@ Migrations.getVersion = function() {
 
 // migrates to the specific version passed in
 Migrations._migrateTo = function(version, rerun) {
-  var self = this;
-  var control = this._getControl(); // Side effect: upserts control document.
-  var currentVersion = control.version;
+  const self = this;
+  const control = this._getControl(); // Side effect: upserts control document.
+  let currentVersion = control.version;
 
   //Avoid unneeded locking, check if migration actually is going to run
   if (!rerun && currentVersion === version) {
@@ -180,8 +186,8 @@ Migrations._migrateTo = function(version, rerun) {
     return;
   }
 
-  var startIdx = this._findIndexByVersion(currentVersion);
-  var endIdx = this._findIndexByVersion(version);
+  const startIdx = this._findIndexByVersion(currentVersion);
+  const endIdx = this._findIndexByVersion(version);
 
   // log.info('startIdx:' + startIdx + ' endIdx:' + endIdx);
   log.info(
@@ -193,7 +199,7 @@ Migrations._migrateTo = function(version, rerun) {
 
   // run the actual migration
   function migrate(direction, idx) {
-    var migration = self._list[idx];
+    const migration = self._list[idx];
 
     if (typeof migration[direction] !== 'function') {
       unlock();
@@ -240,13 +246,13 @@ Migrations._migrateTo = function(version, rerun) {
   }
 
   if (currentVersion < version) {
-    for (var i = startIdx; i < endIdx; i++) {
+    for (let i = startIdx; i < endIdx; i++) {
       migrate('up', i + 1);
       currentVersion = self._list[i + 1].version;
       updateVersion();
     }
   } else {
-    for (var i = startIdx; i > endIdx; i--) {
+    for (let i = startIdx; i > endIdx; i--) {
       migrate('down', i);
       currentVersion = self._list[i - 1].version;
       updateVersion();
@@ -257,9 +263,9 @@ Migrations._migrateTo = function(version, rerun) {
   log.info('Finished migrating.');
 };
 
-// gets the current control record, optionally creating it if non-existant
+// gets the current control record, optionally creating it if non-existent
 Migrations._getControl = function() {
-  var control = this._collection.findOne({ _id: 'control' });
+  const control = this._collection.findOne({ _id: 'control' });
 
   return control || this._setControl({ version: 0, locked: false });
 };
@@ -281,7 +287,7 @@ Migrations._setControl = function(control) {
 
 // returns the migration index in _list or throws if not found
 Migrations._findIndexByVersion = function(version) {
-  for (var i = 0; i < this._list.length; i++) {
+  for (let i = 0; i < this._list.length; i++) {
     if (this._list[i].version === version) return i;
   }
 

diff --git a/migrations_tests.js b/migrations_tests.js
@@ -1,3 +1,5 @@
+import { Migrations } from './migrations_server'
+
 Tinytest.add('Migrates up once and only once.', function(test) {
   var run = []; //keeps track of migrations in here
   Migrations._reset();