EVEREST-107 Simplify Feature Builds #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recharte
force-pushed
the
EVEREST-107-simplify-fb
branch
10 times, most recently
from
7b74dca to
5e912df
Compare
By embedding all the artifacts in a single directory we can remove the complexity of setting the env vars.
recharte
force-pushed
the
EVEREST-107-simplify-fb
branch
from
5e912df to
c1d8451
Compare
oksana-grishchenko
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Thank you Diogo for implementing the changes, it reduces the amount additional manual steps so smoothly!
One suggestion which is not directly related to the PR, but since we are changing the workflow, let's increase the timeout in vs.sh
kubectl wait --for=jsonpath='{.status.readyReplicas}'=3 deployment/percona-version-service > /dev/null
default is 30sec, but today Yusaf faced
error: readyReplicas is not found, so i think it worth to increase the waiting time to 60s at least
Sometimes the default 30s isn't enought and we are seeing error: readyReplicas is not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating the VS deployment manifest during the build process and by embedding the helm chart and CLI binaries into the same FB artifact we can simplify the users experience of installing a feature build. Now, after downloading and unzipping 1 artifact, users only need to run
./helm.shor./cli.shto install the FB.