Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] EVEREST-1735 Disable PITR tooltip for PG with no backups #1040

Merged
merged 21 commits into from
Feb 5, 2025
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
e7f3b0e
fix: disable PITR tooltip for PG with no backups
dianabirs Jan 23, 2025
5430865
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
dianabirs Jan 23, 2025
dec0954
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 23, 2025
fba325c
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 23, 2025
db56534
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 23, 2025
67b481d
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 23, 2025
e1c8319
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 23, 2025
f844f00
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 23, 2025
ae33b4c
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 23, 2025
f49f7ae
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 23, 2025
bf0558e
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 23, 2025
bcfe94e
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 24, 2025
ce50bf0
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 27, 2025
1da5afb
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 28, 2025
cfc0565
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 31, 2025
9cb86df
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Jan 31, 2025
d98d83f
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Feb 3, 2025
b5df930
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Feb 4, 2025
fb93795
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Feb 5, 2025
42232ad
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Feb 5, 2025
d465a7e
Merge branch 'main' into EVEREST-1735-ui-fix-pitr-tooltip-for-pg
percona-robot Feb 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -212,6 +212,9 @@ export const BackupsDetails = ({
'data-testid': 'edit-pitr-button',
}}
editable={editable && !pitrDisabled}
showTooltip={
editable && !backupsEnabled && dbType !== DbType.Postresql
}
disabledEditTooltipText={Messages.titles.createScheduleToEnable}
>
{/*// TODO EVEREST-1066 the width of the columns on the layouts in different places is limited by a different number (but not by the content), a discussion with Design is required*/}
Original file line number Diff line number Diff line change
@@ -34,6 +34,7 @@ export const OverviewSection = ({
dataTestId,
editable,
actionButtonProps,
showTooltip = false,
disabledEditTooltipText = '',
}: OverviewSectionProps) => (
<Grid
@@ -53,7 +54,7 @@ export const OverviewSection = ({
{title}
</Typography>
{actionButtonProps && (
<Tooltip title={!editable ? disabledEditTooltipText : ''}>
<Tooltip title={showTooltip ? disabledEditTooltipText : ''}>
<Box>
<Button
size="small"
Original file line number Diff line number Diff line change
@@ -9,5 +9,6 @@ export type OverviewSectionProps = {
'data-testid'?: string;
};
editable?: boolean;
showTooltip?: boolean;
disabledEditTooltipText?: string;
} & LoadableChildrenProps;

Unchanged files with check annotations Beta

import { EVEREST_CI_NAMESPACES } from '@e2e/constants';

Check failure on line 1 in ui/apps/everest/.e2e/pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts

GitHub Actions / E2E_tests_workflow / e2e (1.23.x, false)

[pr] › ../pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:102:3 › Sharding (psmdb) › Sharding should be correctly displayed on the overview page

1) [pr] › ../pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:102:3 › Sharding (psmdb) › Sharding should be correctly displayed on the overview page Test timeout of 300000ms exceeded.
import { getEnginesVersions } from '@e2e/utils/database-engines';
import { getTokenFromLocalStorage } from '@e2e/utils/localStorage';
import { getClusterDetailedInfo } from '@e2e/utils/storage-class';
) => {
const dbRow = page.getByRole('row').filter({ hasText: name });
await expect(dbRow).toBeVisible({ timeout: 10000 });
await expect(dbRow.getByText(status, { exact: true })).toBeVisible({

Check failure on line 42 in ui/apps/everest/.e2e/utils/table.ts

GitHub Actions / E2E_tests_workflow / e2e (1.23.x, false)

[pr] › ../pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:37:7 › Overview page › Upgrade psmdb version

2) [pr] › ../pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:37:7 › Overview page › Upgrade psmdb version Error: Timed out 600000ms waiting for expect(locator).toBeVisible() Locator: getByRole('row').filter({ hasText: 'psmdb-1-upgrade' }).getByText('Up', { exact: true }) Expected: visible Received: <element(s) not found> Call log: - expect.toBeVisible with timeout 600000ms - waiting for getByRole('row').filter({ hasText: 'psmdb-1-upgrade' }).getByText('Up', { exact: true }) at ../utils/table.ts:42 40 | const dbRow = page.getByRole('row').filter({ hasText: name }); 41 | await expect(dbRow).toBeVisible({ timeout: 10000 }); > 42 | await expect(dbRow.getByText(status, { exact: true })).toBeVisible({ | ^ 43 | timeout: timeout, 44 | }); 45 | }; at waitForStatus (/home/runner/work/everest/everest/ui/apps/everest/.e2e/utils/table.ts:42:58) at /home/runner/work/everest/everest/ui/apps/everest/.e2e/pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:85:11 at /home/runner/work/everest/everest/ui/apps/everest/.e2e/pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:79:9
timeout: timeout,
});
};
name: string,
timeout: number
) => {
await expect(page.getByText(name)).toHaveCount(0, { timeout: timeout });

Check failure on line 58 in ui/apps/everest/.e2e/utils/table.ts

GitHub Actions / E2E_tests_workflow / e2e (1.23.x, false)

[pr] › ../pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:102:3 › Sharding (psmdb) › Sharding should be correctly displayed on the overview page

1) [pr] › ../pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:102:3 › Sharding (psmdb) › Sharding should be correctly displayed on the overview page Error: expect(locator).toHaveCount(expected) Locator: getByText('sharding-psmdb') Expected: 0 Received: 1 Call log: - expect.toHaveCount with timeout 600000ms - waiting for getByText('sharding-psmdb') - locator resolved to 2 elements - unexpected value "2" 290 × locator resolved to 1 element - unexpected value "1" at ../utils/table.ts:58 56 | timeout: number 57 | ) => { > 58 | await expect(page.getByText(name)).toHaveCount(0, { timeout: timeout }); | ^ 59 | }; 60 | at waitForDelete (/home/runner/work/everest/everest/ui/apps/everest/.e2e/utils/table.ts:58:38) at /home/runner/work/everest/everest/ui/apps/everest/.e2e/pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:134:11
};
export const submitWizard = async (page: Page) => {
await page.getByTestId('db-wizard-submit-button').click();
await expect(page.getByTestId('db-wizard-goto-db-clusters')).toBeVisible();

Check failure on line 54 in ui/apps/everest/.e2e/utils/db-wizard.ts

GitHub Actions / E2E_tests_workflow / e2e (1.23.x, false)

[pr] › ../pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:102:3 › Sharding (psmdb) › Sharding should be correctly displayed on the overview page

1) [pr] › ../pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:102:3 › Sharding (psmdb) › Sharding should be correctly displayed on the overview page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toBeVisible() Locator: getByTestId('db-wizard-goto-db-clusters') Expected: visible Received: <element(s) not found> Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByTestId('db-wizard-goto-db-clusters') at ../utils/db-wizard.ts:54 52 | export const submitWizard = async (page: Page) => { 53 | await page.getByTestId('db-wizard-submit-button').click(); > 54 | await expect(page.getByTestId('db-wizard-goto-db-clusters')).toBeVisible(); | ^ 55 | }; 56 | 57 | export const cancelWizard = async (page: Page) => { at submitWizard (/home/runner/work/everest/everest/ui/apps/everest/.e2e/utils/db-wizard.ts:54:64) at goToLastStepByStepAndSubmit (/home/runner/work/everest/everest/ui/apps/everest/.e2e/utils/db-wizard.ts:73:3) at /home/runner/work/everest/everest/ui/apps/everest/.e2e/pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:112:5

Check failure on line 54 in ui/apps/everest/.e2e/utils/db-wizard.ts

GitHub Actions / E2E_tests_workflow / e2e (1.23.x, false)

[pr] › ../pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:102:3 › Sharding (psmdb) › Sharding should be correctly displayed on the overview page

1) [pr] › ../pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:102:3 › Sharding (psmdb) › Sharding should be correctly displayed on the overview page Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toBeVisible() Locator: getByTestId('db-wizard-goto-db-clusters') Expected: visible Received: <element(s) not found> Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByTestId('db-wizard-goto-db-clusters') at ../utils/db-wizard.ts:54 52 | export const submitWizard = async (page: Page) => { 53 | await page.getByTestId('db-wizard-submit-button').click(); > 54 | await expect(page.getByTestId('db-wizard-goto-db-clusters')).toBeVisible(); | ^ 55 | }; 56 | 57 | export const cancelWizard = async (page: Page) => { at submitWizard (/home/runner/work/everest/everest/ui/apps/everest/.e2e/utils/db-wizard.ts:54:64) at goToLastStepByStepAndSubmit (/home/runner/work/everest/everest/ui/apps/everest/.e2e/utils/db-wizard.ts:73:3) at /home/runner/work/everest/everest/ui/apps/everest/.e2e/pr/db-cluster/db-wizard/create-db-cluster/sharding.e2e.ts:112:5

Check failure on line 54 in ui/apps/everest/.e2e/utils/db-wizard.ts

GitHub Actions / E2E_tests_workflow / e2e (1.23.x, false)

[pr] › ../pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:37:7 › Overview page › Upgrade psmdb version

2) [pr] › ../pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:37:7 › Overview page › Upgrade psmdb version Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toBeVisible() Locator: getByTestId('db-wizard-goto-db-clusters') Expected: visible Received: <element(s) not found> Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByTestId('db-wizard-goto-db-clusters') at ../utils/db-wizard.ts:54 52 | export const submitWizard = async (page: Page) => { 53 | await page.getByTestId('db-wizard-submit-button').click(); > 54 | await expect(page.getByTestId('db-wizard-goto-db-clusters')).toBeVisible(); | ^ 55 | }; 56 | 57 | export const cancelWizard = async (page: Page) => { at submitWizard (/home/runner/work/everest/everest/ui/apps/everest/.e2e/utils/db-wizard.ts:54:64) at /home/runner/work/everest/everest/ui/apps/everest/.e2e/pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:73:11 at /home/runner/work/everest/everest/ui/apps/everest/.e2e/pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:72:9

Check failure on line 54 in ui/apps/everest/.e2e/utils/db-wizard.ts

GitHub Actions / E2E_tests_workflow / e2e (1.23.x, false)

[pr] › ../pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:37:7 › Overview page › Upgrade psmdb version

2) [pr] › ../pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:37:7 › Overview page › Upgrade psmdb version Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toBeVisible() Locator: getByTestId('db-wizard-goto-db-clusters') Expected: visible Received: <element(s) not found> Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByTestId('db-wizard-goto-db-clusters') at ../utils/db-wizard.ts:54 52 | export const submitWizard = async (page: Page) => { 53 | await page.getByTestId('db-wizard-submit-button').click(); > 54 | await expect(page.getByTestId('db-wizard-goto-db-clusters')).toBeVisible(); | ^ 55 | }; 56 | 57 | export const cancelWizard = async (page: Page) => { at submitWizard (/home/runner/work/everest/everest/ui/apps/everest/.e2e/utils/db-wizard.ts:54:64) at /home/runner/work/everest/everest/ui/apps/everest/.e2e/pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:73:11 at /home/runner/work/everest/everest/ui/apps/everest/.e2e/pr/db-cluster-details/edit-db-cluster/db-version-upgrade.e2e.ts:72:9
};
export const cancelWizard = async (page: Page) => {
}
}
const BaseTheme = createTheme();

Check warning on line 106 in ui/packages/design/src/themes/base/BaseTheme.tsx

GitHub Actions / CI_checks (lint)

Fast refresh only works when a file only exports components. Move your component(s) to a separate file
const baseThemeOptions = (mode: PaletteMode): ThemeOptions => ({
palette: {
localStorage.removeItem(key);
}
}
}, [localStorageValue]);

Check warning on line 45 in ui/packages/ui-lib/src/table/usePersistentColumnVisibility.ts

GitHub Actions / CI_checks (lint)

React Hook useEffect has a missing dependency: 'key'. Either include it or remove the dependency array
return [localStorageValue, setLocalStorageStateValue];
};
}
setValue(memoryInputName, sizeOptions[resourceSizePerUnit].memory);
}
}, [resourceSizePerUnit, allowDiskInputUpdate, setValue]);

Check warning on line 192 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

GitHub Actions / CI_checks (lint)

React Hook useEffect has missing dependencies: 'cpuInputName', 'diskInputName', 'memoryInputName', and 'sizeOptions'. Either include them or remove the dependency array
useEffect(() => {
if (diskCapacityExceeded) {
} else {
clearErrors(diskInputName);
}
}, [diskCapacityExceeded, clearErrors, setError]);

Check warning on line 200 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

GitHub Actions / CI_checks (lint)

React Hook useEffect has a missing dependency: 'diskInputName'. Either include it or remove the dependency array
useEffect(() => {
if (
) {
setValue(resourceSizePerUnitInputName, ResourceSize.custom);
}
}, [cpu, setValue]);

Check warning on line 209 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

GitHub Actions / CI_checks (lint)

React Hook useEffect has missing dependencies: 'resourceSizePerUnit', 'resourceSizePerUnitInputName', and 'sizeOptions'. Either include them or remove the dependency array
useEffect(() => {
if (
) {
setValue(resourceSizePerUnitInputName, ResourceSize.custom);
}
}, [disk, allowDiskInputUpdate, setValue]);

Check warning on line 219 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

GitHub Actions / CI_checks (lint)

React Hook useEffect has missing dependencies: 'resourceSizePerUnit', 'resourceSizePerUnitInputName', and 'sizeOptions'. Either include them or remove the dependency array
useEffect(() => {
if (
) {
setValue(resourceSizePerUnitInputName, ResourceSize.custom);
}
}, [memory, setValue]);

Check warning on line 228 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

GitHub Actions / CI_checks (lint)

React Hook useEffect has missing dependencies: 'resourceSizePerUnit', 'resourceSizePerUnitInputName', and 'sizeOptions'. Either include them or remove the dependency array
return (
<FormGroup sx={{ mt: 3 }}>
if (authStatus === 'unknown') {
setRedirectRoute(location.pathname);
}
}, [authStatus]);

Check warning on line 19 in ui/apps/everest/src/components/protected-route/ProtectedRoute.tsx

GitHub Actions / CI_checks (lint)

React Hook useEffect has missing dependencies: 'location.pathname' and 'setRedirectRoute'. Either include them or remove the dependency array
// At this point, we're pretty much checking the auth state.
// Later this can be some sort of loading UI
useEffect(() => {
// This allowed us to get an error from zod .superRefine to avoid duplication of checking the schedule with the same time
trigger();
}, [amPm, hour, minute, onDay, weekDay, selectedTime]);

Check warning on line 62 in ui/apps/everest/src/components/schedule-form-dialog/schedule-form-wrapper/schedule-form-wrapper.tsx

GitHub Actions / CI_checks (lint)

React Hook useEffect has a missing dependency: 'trigger'. Either include it or remove the dependency array
useEffect(() => {
if (mode === 'edit' && setSelectedScheduleName) {
await userManager.removeUser();
}
stopAuthorizerFetchLoop();
}, [userManager]);

Check warning on line 131 in ui/apps/everest/src/contexts/auth/auth.provider.tsx

GitHub Actions / CI_checks (lint)

React Hook useCallback has a missing dependency: 'isSsoEnabled'. Either include it or remove the dependency array
const silentlyRenewToken = useCallback(async () => {
const newLoggedUser = await userManager.signinSilent();