Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBM-1333 Warning about breaking ACID during selective restore #182

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

nastena1606
Copy link
Collaborator

No description provided.

Copy link

render bot commented Jun 7, 2024

@nastena1606 nastena1606 force-pushed the PBM-1333-ACID-selective0-restore branch from eb1dd66 to 01ec2e6 Compare June 10, 2024 12:35
@nastena1606 nastena1606 marked this pull request as ready for review June 13, 2024 10:56
Copy link
Member

@igroene igroene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you mention exactly what happens? "break ACID" is not clear... let's say I have a tx involving collections A and B, if I selective restore collection A does it mean data on collection B will be "corrupted"?

@@ -13,6 +13,11 @@ With the selective backup and restore functionality, you have the following opti
3. Restore certain databases and / or collections from a full backup
4. Make a point-in time recovery for the specified databases / collections. Available for replica sets only.

!!! warning

Multi-collection transactions and time series collections are not supported. However, if you use them and try to make a selective restore, it may break ACID because not all operations with this transaction are restored. Thus, from the transaction's point of you, the data consistency may be broken.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Multi-collection transactions and time series collections are not supported. However, if you use them and try to make a selective restore, it may break ACID because not all operations with this transaction are restored. Thus, from the transaction's point of you, the data consistency may be broken.
Multi-collection transactions and time series collections are not supported. However, if you use them and try to make a selective restore, it may break ACID because not all operations with this transaction are restored. PBM only applies oplog records that relate to the selected namespace(s). Thus, from the transaction's point of view, the data consistency may be broken.
For example, if there is a transaction that contains changes for collections A and B, but only A is selected, PBM applies ops only for A and ignores B, which means the transaction is not be fully applied.

@nastena1606 nastena1606 force-pushed the PBM-1333-ACID-selective0-restore branch from 2236697 to e31376e Compare June 17, 2024 09:28
@nastena1606 nastena1606 requested a review from igroene June 17, 2024 09:28
@nastena1606 nastena1606 force-pushed the PBM-1333-ACID-selective0-restore branch from e31376e to b2aec1e Compare June 17, 2024 09:42
Copy link
Member

@igroene igroene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nastena1606 nastena1606 merged commit 88fb2c7 into main Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants