Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-637: add internal. prefix to operator finalizers #1035

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Feb 3, 2025

K8SPG-637 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPG-637

DESCRIPTION

This PR adds an internal. prefix to finalizers that are used only by the operator and are not intended for user use:

  • percona.com/stop-watchers => internal.percona.com/stop-watchers
  • percona.com/delete-backup => internal.percona.com/delete-backup
  • percona.com/delete-restore => internal.percona.com/delete-restore

The change from percona.com/stop-watchers to internal.percona.com/stop-watchers will occur when upgrading to the new operator version, not after the crVersion bump.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@pooknull pooknull marked this pull request as ready for review February 3, 2025 11:14
@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 19 out of 19

commit: 3b390d2
image: perconalab/percona-postgresql-operator:PR-1035-3b390d26d

@hors hors merged commit 7a64257 into main Feb 3, 2025
15 of 17 checks passed
@hors hors deleted the K8SPG-637-rename branch February 3, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants