changed if condition more readable

percona · Jul 11, 2024 · fbf144c · fbf144c
1 parent 3d800e4
commit fbf144c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/bin/pt-mysql-summary b/bin/pt-mysql-summary
@@ -2098,14 +2098,10 @@ section_innodb () {
 
    local mysql_version=$(get_var version "$variables_file" | awk -F'-' '{print $1}')
    local transaction_isolation_var="tx_isolation"
-   version_greater_equal() { # Function to compare versions
-      [ "$(printf '%s\n' "$1" "$2" | sort -V | head -n1)" = "$2" ]
-   }
-   if version_greater_equal "$mysql_version" "5.7.20"; then # true if version >= 5.7.20
+   if [ "$mysql_version" '>' "5.7.19" ]; then # true if version >= 5.7.20
          transaction_isolation_var="transaction_isolation"
    fi
 
-
    name_val "Buffer Pool Fill"   "$(fuzzy_pct ${bp_fill} ${bp_pags})"
    name_val "Buffer Pool Dirty"  "$(fuzzy_pct ${bp_dirt} ${bp_pags})"
 

diff --git a/lib/bash/report_mysql_info.sh b/lib/bash/report_mysql_info.sh
@@ -1018,14 +1018,10 @@ section_innodb () {
    # dynamically allocate variable name - transaction_isolation
    local mysql_version=$(get_var version "$variables_file" | awk -F'-' '{print $1}')
    local transaction_isolation_var="tx_isolation"
-   version_greater_equal() { # Function to compare versions
-      [ "$(printf '%s\n' "$1" "$2" | sort -V | head -n1)" = "$2" ]
-   }
-   if version_greater_equal "$mysql_version" "5.7.20"; then # true if version >= 5.7.20
+   if [ "$mysql_version" '>' "5.7.19" ]; then # true if version >= 5.7.20
          transaction_isolation_var="transaction_isolation"
    fi
 
-
    name_val "Buffer Pool Fill"   "$(fuzzy_pct ${bp_fill} ${bp_pags})"
    name_val "Buffer Pool Dirty"  "$(fuzzy_pct ${bp_dirt} ${bp_pags})"