Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
egegunes committed Jun 14, 2023
1 parent f10763c commit b0cae12
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/apis/pxc/v1/pxc_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ func (cr *PerconaXtraDBCluster) CheckNSetDefaults(serverVersion *version.ServerV
c.ProxySQL.ImagePullPolicy = corev1.PullAlways
}

if cr.CompareVersionWith("1.12.0") >= 0 && len(c.ProxySQL.PXCHandler) == 0 {
if cr.CompareVersionWith("1.13.0") >= 0 && len(c.ProxySQL.PXCHandler) == 0 {
c.ProxySQL.PXCHandler = "internal"
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/pxc/app/statefulset/proxysql.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func (c *Proxy) AppContainer(spec *api.PodSpec, secrets string, cr *api.PerconaX
}
}

if cr.CompareVersionWith("1.12.0") >= 0 {
if cr.CompareVersionWith("1.13.0") >= 0 {
appc.Env = append(appc.Env, corev1.EnvVar{
Name: "PXC_HANDLER",
Value: cr.Spec.ProxySQL.PXCHandler,
Expand Down Expand Up @@ -244,7 +244,7 @@ func (c *Proxy) SidecarContainers(spec *api.PodSpec, secrets string, cr *api.Per
},
}

if cr.CompareVersionWith("1.12.0") >= 0 {
if cr.CompareVersionWith("1.13.0") >= 0 {
pxcMonit.Env = append(pxcMonit.Env, corev1.EnvVar{
Name: "PXC_HANDLER",
Value: cr.Spec.ProxySQL.PXCHandler,
Expand Down

0 comments on commit b0cae12

Please sign in to comment.