Pxc 4607 #2018
Closed
Pxc 4607 #2018
+158
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align privileges assignment as for mysql_user
|
@ParveezBaig @kamil-holubicki can you check it please ? this should fix the 4067 |
kamil-holubicki
requested changes
Feb 3, 2025
| @@ -358,12 +358,14 @@ setup_clone_plugin() | |||
| WSREP_OFF="" # joiner does not have replication enabled | |||
| fi | |||
| $MYSQL_ACLIENT -e "${WSREP_OFF}INSTALL PLUGIN CLONE SONAME 'mysql_clone.so';" | |||
| CLEANUP_CLONE_PLUGIN="yes" | |||
| if [ "$ROLE" == "donor" ]; then | |||
There was a problem hiding this comment.
It is not consistent across the script how we do the comparison. Sometimes it is == and sometimes it it = (just 4 lines above).
= is posix compatible and should be used with single brackets [...]
== is bash only compatible and should be used with double brackets [[...]]
Would it be possible to have it consistent?
There was a problem hiding this comment.
will review all in a different branch/pr
| @@ -392,7 +394,7 @@ setup_clone_plugin() | |||
| [ "$SERVER_SSL_KEY" = "NULL" ] && SERVER_SSL_KEY= | |||
| [ "$SERVER_SSL_CA" = "NULL" ] && SERVER_SSL_CA= | |||
|
|
|||
| if [ "$CLONE_SSL_CERT" = "NULL" -o "$CLONE_SSL_KEY" = "NULL" ] | |||
| if [ "$CLONE_SSL_CERT" == "NULL" -o "$CLONE_SSL_CERT" = "" ] | |||
There was a problem hiding this comment.
Mixture of single = and double == in one if
Closed
…ction of the code: DROP USER IF EXISTS 'mysql.pxc.sst.user'@'localhost'; $CLEANUP_CLONE_PLUGIN_SQL Just moving the variable in different line fix the issue. this is quick and dirty fix but it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for PXC-4607 (synchronize clone plugin persistency)