(8.0) PXC-4498: PXC node "stalls" and causes the cluster to stop responding #2021
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -387,19 +389,142 @@ page_no_t trx_sysf_rseg_find_page_no(ulint rseg_id) { | |||
|
|
|||
| #ifdef WITH_WSREP | |||
|
|
|||
| #define WSREP_UUID_SIZE 16 | |||
There was a problem hiding this comment.
macro WSREP_UUID_SIZE used to declare a constant; consider using a constexpr constant
| unsigned char xid_uuid[WSREP_UUID_SIZE]; | ||
| long long xid_seqno = read_wsrep_xid_seqno(xid); | ||
| read_wsrep_xid_uuid(xid, xid_uuid); | ||
| if (!memcmp(xid_uuid, trx_sys_cur_xid_uuid, WSREP_UUID_SIZE) && |
There was a problem hiding this comment.
implicit conversion int -> bool
| if (!memcmp(xid_uuid, trx_sys_cur_xid_uuid, WSREP_UUID_SIZE) && | |
| if ((memcmp(xid_uuid, trx_sys_cur_xid_uuid, WSREP_UUID_SIZE) == 0) && |
| // ut_ad((current_thd && wsrep_thd_is_in_nbo(current_thd)) || | ||
| // xid_seqno >= trx_sys_cur_xid_seqno); | ||
| } else { | ||
| memcpy(trx_sys_cur_xid_uuid, xid_uuid, 16); |
There was a problem hiding this comment.
16 is a magic number; consider replacing it with a named constant
storage/innobase/trx/trx0sys.cc
Outdated
| } | ||
| trx_sys_cur_xid_seqno = xid_seqno; | ||
|
|
||
| char uuid_str[40] = { 0, }; |
There was a problem hiding this comment.
40 is a magic number; consider replacing it with a named constant
storage/innobase/trx/trx0sys.cc
Outdated
| trx_sys_cur_xid_seqno = xid_seqno; | ||
|
|
||
| char uuid_str[40] = { 0, }; | ||
| wsrep_uuid_print((const wsrep_uuid_t *)xid_uuid, uuid_str, |
There was a problem hiding this comment.
do not use C-style cast to convert between unrelated types
storage/innobase/trx/trx0sys.cc
Outdated
| trx_sys_cur_xid_seqno = xid_seqno; | ||
|
|
||
| char uuid_str[40] = { 0, }; | ||
| wsrep_uuid_print((const wsrep_uuid_t *)xid_uuid, uuid_str, |
There was a problem hiding this comment.
C-style casts are discouraged; use reinterpret_cast
| wsrep_uuid_print((const wsrep_uuid_t *)xid_uuid, uuid_str, | |
| wsrep_uuid_print(reinterpret_cast<const wsrep_uuid_t *>(xid_uuid), uuid_str, |
| } else { | ||
| #ifdef UNIV_DEBUG |
There was a problem hiding this comment.
do not use else after return
| } else { | |
| #ifdef UNIV_DEBUG | |
| } #ifdef UNIV_DEBUG |
| } else { | ||
| #ifdef UNIV_DEBUG | ||
| wsrep_xid_sanity_check(xid); | ||
| #endif /* UNIV_DEBUG */ | ||
| } |
There was a problem hiding this comment.
do not use else after return
| } | |
kamil-holubicki
force-pushed
the
PXC-4498-8.0
branch
from
6640832 to
e542383
Compare
kamil-holubicki
changed the title
|
https://pxc.cd.percona.com/view/8.0%20parallel%20MTR/job/pxc-8.0-pipeline-parallel-mtr/3058/ All failures are instabilities or timeouts (long tests) |
https://perconadev.atlassian.net/browse/PXC-4498 https://perconadev.atlassian.net/browse/PXC-4390 Removed wsrep_group_commit_queue. The queue works only for variables used for debug assertions. The actual write to sys_header is done without the protection of the queue. As the queue is not enforcing proper order of xid storing in sys_header, but was in the past and still is the source of deadlocks - removing.
kamil-holubicki
force-pushed
the
PXC-4498-8.0
branch
from
e542383 to
c65c69d
Compare
| } | ||
| trx_sys_cur_xid_seqno = xid_seqno; | ||
|
|
||
| char uuid_str[40] = { |
There was a problem hiding this comment.
40 is a magic number; consider replacing it with a named constant
| char uuid_str[40] = { | ||
| 0, | ||
| }; | ||
| wsrep_uuid_print((const wsrep_uuid_t *)xid_uuid, uuid_str, sizeof(uuid_str)); |
There was a problem hiding this comment.
do not use C-style cast to convert between unrelated types
| char uuid_str[40] = { | ||
| 0, | ||
| }; | ||
| wsrep_uuid_print((const wsrep_uuid_t *)xid_uuid, uuid_str, sizeof(uuid_str)); |
There was a problem hiding this comment.
C-style casts are discouraged; use reinterpret_cast
| wsrep_uuid_print((const wsrep_uuid_t *)xid_uuid, uuid_str, sizeof(uuid_str)); | |
| wsrep_uuid_print(reinterpret_cast<const wsrep_uuid_t *>(xid_uuid), uuid_str, sizeof(uuid_str)); |
https://perconadev.atlassian.net/browse/PXC-4498
https://perconadev.atlassian.net/browse/PXC-4390
Removed wsrep_group_commit_queue.