PMM-8641 PMM v3 API breaking changes #6435
ademidoffmain.yml
on: pull_request
Checks
5m 55s
Slack Notification success
0s
Slack Notification failure
14s
Annotations
10 errors
|
Checks:
api-tests/server/settings_test.go#L427
serverClient.Default.Server.ChangeSettings undefined (type "github.com/percona/pmm/api/server/v1/json/client/server".ClientService has no field or method ChangeSettings)
|
|
Checks:
api-tests/server/settings_test.go#L429
cannot use publicAddress (variable of type string) as *string value in struct literal (typecheck)
|
|
Checks:
agent/config/config_test.go#L156
string `--config-file=` has 6 occurrences, make it a constant (goconst)
|
|
Checks:
managed/models/agent_helpers.go#L606
string `cannot use push_metrics_enabled with pmm_agent version=%q,` has 3 occurrences, make it a constant (goconst)
|
|
Checks:
managed/models/agent_helpers.go#L580
string `/agent_id/` has 4 occurrences, make it a constant (goconst)
|
|
Checks:
managed/models/agent_helpers.go#L607
string ` it doesn't support it, minimum supported version=%q` has 3 occurrences, make it a constant (goconst)
|
|
Checks:
managed/models/agent_model.go#L443
string `.TextFiles.` has 5 occurrences, make it a constant (goconst)
|
|
Checks:
managed/services/supervisord/supervisord.go#L537
string `.ini` has 3 occurrences, make it a constant (goconst)
|
|
Checks:
managed/models/database_test.go#L156
string `INSERT INTO services (service_id, service_type, service_name, node_id, environment, cluster, replication_set, address, port, socket, external_group, created_at, updated_at) ` has 5 occurrences, make it a constant (goconst)
|
|
Checks:
managed/models/database_test.go#L284
string `INSERT INTO agents (agent_id, agent_type, runs_on_node_id, pmm_agent_id, node_id, service_id, disabled, status, created_at, updated_at, tls, tls_skip_verify, max_query_length, query_examples_disabled, comments_parsing_disabled, max_query_log_size, table_count_tablestats_group_limit, rds_basic_metrics_disabled, rds_enhanced_metrics_disabled, push_metrics, expose_exporter) ` has 4 occurrences, make it a constant (goconst)
|