PMM-10974 PR for merge to v3 (Fallback to PGSS in case of not available PGSM). #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PMM-12872 Fallback to PGSS in case of not available PGSM. * PMM-12872 Lint. * PMM-12872 Lint. * PMM-12872 Add test for PostgreSQLOptions. * PMM-12872 Small change in if. * Update api/agentpb/agent.proto Co-authored-by: Alex Demidoff <[email protected]> * Update managed/services/management/postgresql.go Co-authored-by: Alex Demidoff <[email protected]> * PMM-12872 Remove nil check in if. * PMM-12872 Gen. * PMM-10974 Warning message on pmm-admin side. * PMM-10974 Change warning message. --------- Co-authored-by: Alex Demidoff <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #2846 +/- ##
==========================================
- Coverage 43.52% 43.47% -0.05%
==========================================
Files 362 362
Lines 42404 42420 +16
==========================================
- Hits 18455 18443 -12
- Misses 22378 22407 +29
+ Partials 1571 1570 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BupycHuk
approved these changes
Feb 26, 2024
ademidoff
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-10974
PR merged into v2: https://github.com/percona/pmm/pull/2827/files