Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12333 Make pmm-client tarball installation more user-friendly #2856

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

surbhat1595
Copy link
Contributor

@surbhat1595 surbhat1595 commented Feb 28, 2024

PMM-12333

Link to the Feature Build: SUBMODULES-3585

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@surbhat1595 surbhat1595 requested a review from a team as a code owner February 28, 2024 09:51
@surbhat1595 surbhat1595 requested review from idoqo, JiriCtvrtka and talhabinrizwan and removed request for a team February 28, 2024 09:51
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.24%. Comparing base (4d55273) to head (e1bb2c7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2856      +/-   ##
==========================================
- Coverage   42.27%   42.24%   -0.04%     
==========================================
  Files         396      396              
  Lines       50123    50123              
==========================================
- Hits        21188    21172      -16     
- Misses      26932    26948      +16     
  Partials     2003     2003              
Flag Coverage Δ
admin 11.56% <ø> (-0.05%) ⬇️
agent 53.19% <ø> (-0.14%) ⬇️
managed 42.80% <ø> (ø)
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

build/scripts/install_tarball Outdated Show resolved Hide resolved
@BupycHuk
Copy link
Member

@surbhat1595 do we have FB for it?

@surbhat1595
Copy link
Contributor Author

@BupycHuk Yes, I have created a FB for it.

@BupycHuk
Copy link
Member

@surbhat1595 what's the status of this task? As far as I see in jira it's not in progress, but Open

@surbhat1595
Copy link
Contributor Author

@BupycHuk The status has to be changed to "In Progress", I think this should be changed by someone in the PMM team. Once the changes are merged, the script can be tested by the QA.

@surbhat1595 surbhat1595 merged commit e4d3345 into main Mar 28, 2024
30 checks passed
@surbhat1595 surbhat1595 deleted the PMM-12333 branch March 28, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants