Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13292 Add INITIALIZATION_ERROR status for process initialization failure #2935

Merged
merged 21 commits into from
Aug 27, 2024

Conversation

GuanqunYang193
Copy link
Contributor

@GuanqunYang193 GuanqunYang193 commented Mar 29, 2024

PMM-13292

what

  • Added a new status of process, used for showing the process failed when initialization.
  • Supervisor will initiate a port selection and restart the process initialization if failure is detected during the process initialization.

why

If the process fails to start (due to, for instance, a port conflict), the previous design will attempt to retry the process using the same port.

how

In this new commit, the supervisor will confirm the successful initialization of the process. If the initialization fails, it will make up to three attempts to start the process again.

@GuanqunYang193 GuanqunYang193 requested review from BupycHuk and a team as code owners March 29, 2024 01:09
@GuanqunYang193 GuanqunYang193 requested review from idoqo and JiriCtvrtka and removed request for a team March 29, 2024 01:09
@GuanqunYang193 GuanqunYang193 changed the title add process init fail status Add INITIALIZATION_ERROR statue for process initialization failure Mar 29, 2024
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just few comments

agent/agents/process/process.go Outdated Show resolved Hide resolved
agent/agents/supervisor/supervisor_test.go Show resolved Hide resolved
agent/agents/supervisor/supervisor_test.go Show resolved Hide resolved
api/inventorypb/agent_status.dot Show resolved Hide resolved
api/inventorypb/agent_status.proto Outdated Show resolved Hide resolved
api/inventorypb/agent_status.proto Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 43.40%. Comparing base (7c580b4) to head (9055176).
Report is 1 commits behind head on main.

Files Patch % Lines
agent/agents/supervisor/supervisor.go 75.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2935      +/-   ##
==========================================
+ Coverage   43.33%   43.40%   +0.07%     
==========================================
  Files         399      399              
  Lines       41662    41692      +30     
==========================================
+ Hits        18054    18097      +43     
+ Misses      21593    21580      -13     
  Partials     2015     2015              
Flag Coverage Δ
admin 11.67% <ø> (+0.05%) ⬆️
agent 53.03% <86.66%> (+0.28%) ⬆️
managed 44.41% <ø> (ø)
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BupycHuk BupycHuk changed the title Add INITIALIZATION_ERROR statue for process initialization failure PMM-13292 Add INITIALIZATION_ERROR statue for process initialization failure Aug 3, 2024
@ademidoff ademidoff merged commit 070cc40 into percona:main Aug 27, 2024
31 checks passed
@GuanqunYang193 GuanqunYang193 changed the title PMM-13292 Add INITIALIZATION_ERROR statue for process initialization failure PMM-13292 Add INITIALIZATION_ERROR status for process initialization failure Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants