Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 Update pg_query_go #2965

Open
wants to merge 21 commits into
base: v3
Choose a base branch
from
Open

PMM-7 Update pg_query_go #2965

wants to merge 21 commits into from

Conversation

BupycHuk
Copy link
Member

PMM-7

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested review from a team and JiriCtvrtka as code owners April 18, 2024 09:57
@BupycHuk BupycHuk requested review from ademidoff and idoqo and removed request for a team April 18, 2024 09:57
Comment on lines 2 to 7
"error": "error on parsing sql query: subquery in FROM must have an alias"
"tables": [
"credit_card_wo_complaints",
"without_complaints"
],
"error": ""
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query by itself is incorrect but I see no harm in extracting tables from incorrect query

- { mysql: 'mariadb:10.3', mongo: 'percona/percona-server-mongodb:4.4', postgres: 'postgres:9.5', pmm_server: 'perconalab/pmm-server:dev-latest' }
- { mysql: 'mariadb:10.4', postgres: 'postgres:9.6', pmm_server: 'perconalab/pmm-server:dev-latest' }
- { mysql: 'mariadb:10.2', mongo: 'mongo:4.4', postgres: 'postgres:10', pmm_server: 'perconalab/pmm-server:dev-latest' }
- { mysql: 'mariadb:10.3', mongo: 'percona/percona-server-mongodb:4.4', postgres: 'postgres:11', pmm_server: 'perconalab/pmm-server:dev-latest' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why we dropped the minor versions though (e.g testing on 10.x)

@BupycHuk BupycHuk changed the base branch from main to v3 April 24, 2024 13:38
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.51%. Comparing base (9f00573) to head (6efc356).

Files with missing lines Patch % Lines
agent/utils/tests/mongodb.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2965      +/-   ##
==========================================
- Coverage   44.77%   44.51%   -0.26%     
==========================================
  Files         360      360              
  Lines       36153    36156       +3     
==========================================
- Hits        16186    16095      -91     
- Misses      18305    18406     +101     
+ Partials     1662     1655       -7     
Flag Coverage Δ
admin 11.54% <ø> (ø)
agent 51.96% <50.00%> (-1.07%) ⬇️
managed 46.85% <ø> (+<0.01%) ⬆️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff
Copy link
Member

@BupycHuk
FYI: we have merged its counterpart to the main branch.

"winningPlan": map[string]interface{}{"stage": "EOF"},
}
mongoDBVersion := tests.MongoDBVersion(t, client)
fmt.Printf("MongoDB version: %s\n", mongoDBVersion)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
use of fmt.Printf forbidden by pattern ^(fmt\.Print(|f|ln)|print|println)$ (forbidigo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants