PMM-7 fix updates test #3050
Merged
PMM-7 fix updates test #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3050 +/- ##
==========================================
+ Coverage 43.33% 44.54% +1.21%
==========================================
Files 400 367 -33
Lines 41631 35555 -6076
==========================================
- Hits 18041 15839 -2202
+ Misses 21573 18084 -3489
+ Partials 2017 1632 -385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
idoqo
requested review from
BupycHuk,
JiriCtvrtka,
ademidoff and
a team
and removed request for
a team
ademidoff
approved these changes
Jun 26, 2024
| @@ -252,7 +252,7 @@ func TestUpdater(t *testing.T) { | |||
| latest, err := u.latest(context.Background()) | |||
| require.NoError(t, err) | |||
| assert.NotNil(t, latest) | |||
| assert.True(t, strings.HasPrefix(latest.Version.String(), "2.41."), "latest version of PMM 2 should have prefix 2.41.") | |||
| assert.True(t, strings.HasPrefix(latest.Version.String(), "2."), "latest version of PMM 2 should have prefix 2.") | |||
There was a problem hiding this comment.
LGTM
Shouldn't we add the same || strings.HasPrefix(res.Payload.Installed.Version, "3.") to be prepared for v3?
BupycHuk
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7
Fixes for api tests and unit tests related to PMM server versions.
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: