PMM-12940 Run watchtower with AMI. #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3074 +/- ##
==========================================
- Coverage 44.61% 44.58% -0.04%
==========================================
Files 358 357 -1
Lines 35628 35540 -88
==========================================
- Hits 15895 15845 -50
+ Misses 18108 18073 -35
+ Partials 1625 1622 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
JiriCtvrtka
approved these changes
Jul 23, 2024
idoqo
approved these changes
Jul 23, 2024
build/Makefile
Outdated
| @@ -1,5 +1,6 @@ | |||
| export PACKER_CACHE_DIR := .cache | |||
| export PACKER_VERSION := 1.9.4 | |||
| export PMM_SERVER_IMAGE ?= docker.io/perconalab/pmm-server-fb:PR-3664-e536f77 | |||
There was a problem hiding this comment.
Is the image name a left over? Or we want to keep it until FB is tested?
There was a problem hiding this comment.
Yes, should be replaced with perconalab/pmm-server:3-dev-latest before merge
ademidoff
force-pushed
the
v3
branch
3 times, most recently
from
8421bc2
to
da25a0c
Compare
…watchtower-pmm-nurlan # Conflicts: # api/server/v1/server_grpc.pb.go # descriptor.bin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12940
PMM-13053
PMM-13063
Link to the Feature Build: SUBMODULES-3664
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: