Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-13392 Strip agent status prefix in pmm-admin status cmd #3229

Merged
merged 4 commits into from
Oct 9, 2024
Merged

PMM-13392 Strip agent status prefix in pmm-admin status cmd #3229

merged 4 commits into from
Oct 9, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Oct 9, 2024 •
edited
Loading

PMM-13392

Link to the Feature Build: SUBMODULES-3727

@ademidoff ademidoff changed the base branch from main to v3 October 9, 2024 04:56
@ademidoff ademidoff mentioned this pull request Oct 9, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.62%. Comparing base (e20ac7c) to head (0341c53).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
admin/commands/inventory/list_agents.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##               v3    #3229   +/-   ##
=======================================
  Coverage   44.62%   44.62%           
=======================================
  Files         357      357           
  Lines       35719    35721    +2     
=======================================
+ Hits        15941    15942    +1     
- Misses      18154    18155    +1     
  Partials     1624     1624
Flag Coverage Δ
admin 11.54% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review October 9, 2024 05:12
@ademidoff ademidoff requested a review from a team as a code owner October 9, 2024 05:12
@ademidoff ademidoff requested review from BupycHuk and idoqo and removed request for a team October 9, 2024 05:12
@BupycHuk
Copy link
Member

BupycHuk commented Oct 9, 2024

What about pmm-admin list command?

@ademidoff
Copy link
Member Author

ademidoff commented Oct 9, 2024 •
edited
Loading

What about pmm-admin list command?

It's been fixed in another PR.

@ademidoff ademidoff enabled auto-merge (squash) October 9, 2024 16:44
@ademidoff ademidoff merged commit eb12a93 into v3 Oct 9, 2024
14 checks passed
@ademidoff ademidoff deleted the PMM-13392-strip-agent-status-prefix branch October 9, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BupycHuk BupycHuk BupycHuk approved these changes

@idoqo idoqo idoqo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ademidoff @BupycHuk @idoqo