Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12775 Install watchtower with PMM. #3231

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

BupycHuk
Copy link
Member

@BupycHuk BupycHuk commented Oct 9, 2024

PMM-12775

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested a review from a team as a code owner October 9, 2024 23:02
@BupycHuk BupycHuk requested review from idoqo and JiriCtvrtka and removed request for a team October 9, 2024 23:02
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.59%. Comparing base (eb12a93) to head (258e2fa).

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3231      +/-   ##
==========================================
- Coverage   44.62%   44.59%   -0.04%     
==========================================
  Files         357      357              
  Lines       35721    35721              
==========================================
- Hits        15942    15928      -14     
- Misses      18155    18169      +14     
  Partials     1624     1624              
Flag Coverage Δ
admin 11.49% <ø> (-0.06%) ⬇️
agent 52.81% <ø> (-0.14%) ⬇️
managed 46.69% <ø> (ø)
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

get-pmm.sh Outdated Show resolved Hide resolved
@BupycHuk BupycHuk requested a review from idoqo October 10, 2024 08:26
show_message
}

parse_params "$@"

main
die "Enjoy Percona Monitoring and Management!" 0
# TODO: Update script from PMM 2 to PMM 3

}# TODO: reuse watchtower token from older pmm instance or watchtower
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing empty line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants